fork/gdu

git clone https://git.julia.blue/fork/gdu

VXNCXNXfix(device): skip malformed mount lines (#625)81b1d22

ignore
3.6 KiB84 linesraw
1//go:build linux
2
3package device
4
5import (
6	"strings"
7	"testing"
8
9	"github.com/stretchr/testify/assert"
10)
11
12func TestGetDevicesInfo(t *testing.T) {
13	getter := LinuxDevicesInfoGetter{MountsPath: "/proc/mounts"}
14	devices, _ := getter.GetDevicesInfo()
15	assert.IsType(t, Devices{}, devices)
16}
17
18func TestGetDevicesInfoFail(t *testing.T) {
19	getter := LinuxDevicesInfoGetter{MountsPath: "/xxxyyy"}
20	_, err := getter.GetDevicesInfo()
21	assert.Equal(t, "open /xxxyyy: no such file or directory", err.Error())
22}
23
24func TestSnapMountsNotShown(t *testing.T) {
25	mounts, _ := readMountsFile(strings.NewReader(`/dev/loop4 /var/lib/snapd/snap/core18/1944 squashfs ro,nodev,relatime 0 0
26/dev/loop3 /var/lib/snapd/snap/core20/904 squashfs ro,nodev,relatime 0 0
27/dev/nvme0n1p1 /boot vfat rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro 0 0`))
28
29	devices, err := processMounts(mounts, true)
30	assert.Len(t, devices, 1)
31	assert.Nil(t, err)
32}
33
34func TestZfsMountsShown(t *testing.T) {
35	mounts, _ := readMountsFile(strings.NewReader(`rootpool/opt /opt zfs rw,nodev,relatime,xattr,posixacl 0 0
36rootpool/usr/local /usr/local zfs rw,nodev,relatime,xattr,posixacl 0 0
37rootpool/home/root /root zfs rw,nodev,relatime,xattr,posixacl 0 0
38rootpool/usr/games /usr/games zfs rw,nodev,relatime,xattr,posixacl 0 0
39rootpool/home /home zfs rw,nodev,relatime,xattr,posixacl 0 0
40/dev/loop4 /var/lib/snapd/snap/core18/1944 squashfs ro,nodev,relatime 0 0
41/dev/loop3 /var/lib/snapd/snap/core20/904 squashfs ro,nodev,relatime 0 0
42/dev/nvme0n1p1 /boot vfat rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro 0 0`))
43
44	devices, err := processMounts(mounts, true)
45	assert.Len(t, devices, 6)
46	assert.Nil(t, err)
47}
48
49func TestNfsMountsShown(t *testing.T) {
50	// nolint: lll // Why: Test data
51	mounts, _ := readMountsFile(strings.NewReader(`host1:/dir1/ /mnt/dir1 nfs4 rw,nosuid,nodev,noatime,nodiratime,vers=4.2,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=192.168.1.1,fsc,local_lock=none,addr=192.168.1.2 0 0
52host2:/dir2/ /mnt/dir2 nfs rw,relatime,vers=3,rsize=524288,wsize=524288,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=192.168.1.3,mountvers=3,mountport=38081,mountproto=udp,fsc,local_lock=none,addr=192.168.1.4 0 0`))
53
54	devices, err := processMounts(mounts, true)
55	assert.Len(t, devices, 2)
56	assert.Equal(t, "host1:/dir1/", devices[0].Name)
57	assert.Equal(t, "/mnt/dir1", devices[0].MountPoint)
58	assert.Nil(t, err)
59}
60
61func TestMalformedMountsLinesAreSkipped(t *testing.T) {
62	mounts, err := readMountsFile(strings.NewReader(`
63/dev/nvme0n1p1
64/dev/nvme0n1p2 /boot
65/dev/nvme0n1p3 /home ext4 rw,relatime 0 0`))
66
67	assert.Nil(t, err)
68	assert.Len(t, mounts, 1)
69	assert.Equal(t, "/dev/nvme0n1p3", mounts[0].Name)
70	assert.Equal(t, "/home", mounts[0].MountPoint)
71	assert.Equal(t, "ext4", mounts[0].Fstype)
72}
73
74func TestMountsWithSpaces(t *testing.T) {
75	// nolint: lll // Why: Test data
76	mounts, _ := readMountsFile(strings.NewReader(`host1:/dir1/ /mnt/dir\040with\040spaces nfs4 rw,nosuid,nodev,noatime,nodiratime,vers=4.2,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=192.168.1.1,fsc,local_lock=none,addr=192.168.1.2 0 0
77host2:/dir2/ /mnt/dir2 nfs rw,relatime,vers=3,rsize=524288,wsize=524288,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=192.168.1.3,mountvers=3,mountport=38081,mountproto=udp,fsc,local_lock=none,addr=192.168.1.4 0 0`))
78
79	devices, err := processMounts(mounts, true)
80	assert.Len(t, devices, 2)
81	assert.Equal(t, "host1:/dir1/", devices[0].Name)
82	assert.Equal(t, "/mnt/dir with spaces", devices[0].MountPoint)
83	assert.Nil(t, err)
84}