<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>CONTRIBUTING.md - fork/raki @ master</title>
<meta name="description" content="CONTRIBUTING.md in fork/raki at master.">
<meta property="og:title" content="CONTRIBUTING.md - fork/raki @ master">
<meta property="og:description" content="CONTRIBUTING.md in fork/raki at master.">
<meta property="og:type" content="website">
<meta property="og:site_name" content="git.julia.blue">
<link rel="stylesheet" href="/css/style.css?v=62">
<script type="module" src="/js/main.js?v=62"></script>
</head>
<body>
<main data-ref="master" data-tip="3f238306fc4f1784aaeade9381cf144a1c95aaa4">
<noscript>
  <div class="callout">
    <p>
      hey! this is a static git repo viewer. commit diffs, file history,
      older commits and other revisions won't load without javascript.
    </p>
    <p>
      you are still able to view source files on branch/tag tips,
      but the experience is degraded.
    </p>
  </div>
</noscript>
<header class="repo"><div>
<h1>fork/raki</h1>
</div>
<pre class="clone">git clone https://git.julia.blue/fork/raki</pre>
</header>
<p class="snapshot-commit"><span class="commit-author">Norimasa Takana</span><span class="commit-message" data-commit="0bc292ad7c899dc01d249871c007b5f0f19b47e3">Merge pull request #21 from Alignof/develop</span><span class="snapshot-sha sha" data-commit="0bc292ad7c899dc01d249871c007b5f0f19b47e3">0bc292a</span><time datetime="2024-09-05T00:18:51+09:00" title="2024-09-05 00:18:51 +0900">2024-09-05</time></p>
<header class="topbar"><details class="switcher"><summary>master</summary><div class="menu"><strong>branches</strong><a class="current" href="/fork/raki/ref/master/">master</a><a class="all" href="/fork/raki/refs">all refs →</a></div></details><nav class="crumbs"><a href="/fork/raki/">raki</a> / <span class="cur">CONTRIBUTING.md</span></nav>
<span class="view-stats"><span>7.7 KiB</span><span>252 lines</span></span><span class="actions"><a class="raw" href="/fork/raki/raw/6297e5887d12b6b3fc2a41bf941cf999715f8327/CONTRIBUTING.md">raw</a></span></header>
<div class="markdown-view"><input type="radio" name="markdown-view" id="markdown-rendered" checked><label for="markdown-rendered">rendered</label><input type="radio" name="markdown-view" id="markdown-code"><label for="markdown-code">code</label><section class="readme rendered"><h1>Contribution Guide</h1>
<h2>What can I do?</h2>
<p>Any contribution is welcome.</p>
<ul>
<li>Correction typo in document.</li>
<li>Pull request for new extension supporting</li>
<li>Point out the lack of API</li>
<li>Correction of English expressions (If you are better at English than DeepL, here's your chance to be a contributor!)</li>
</ul>
<h2>How to add a supporting extension?</h2>
<p>Zicntr extension as an example.<br />
See: <a href="https://github.com/Alignof/raki/pull/16">https://github.com/Alignof/raki/pull/16</a></p>
<h3>Add the definition of an instruction</h3>
<p>First, list the instructions that the extension has in an Enum.</p>
<pre class="language-bash"><a-f>any_editor_command</a-f> src/instruction/zicntr_extension.rs</pre>
<pre class="language-rust"><a-c>/// Insturctions in Zicntr Extension.
</a-c><a-at>#</a-at><a-p>[</a-p><a-at>allow</a-at><a-p>(</a-p><a-at>non_camel_case_types</a-at><a-p>)]</a-p>
<a-at>#</a-at><a-p>[</a-p><a-at>derive</a-at><a-p>(</a-p><a-cr>Debug</a-cr><a-p>,</a-p><a-at> </a-at><a-cr>PartialEq</a-cr><a-p>)]</a-p>
<a-k>pub</a-k> <a-k>enum</a-k> <a-t>ZicntrOpcode</a-t> <a-p>{</a-p>
    <a-c>// For Rv32, these instructions indicate lower 32 bits.</a-c>
    <a-c>// For Rv64, these instructions do not exist.</a-c>
    <a-cr>RDCYCLE_H</a-cr><a-p>,</a-p>
    <a-cr>RDTIME_H</a-cr><a-p>,</a-p>
    <a-cr>RDINSTRET_H</a-cr><a-p>,</a-p>

    <a-c>// For Rv32, these instructions indicate upper 32 bits.</a-c>
    <a-c>// For Rv64, these instructions can access the full 64-bit CSRs directly.</a-c>
    <a-cr>RDCYCLE</a-cr><a-p>,</a-p>
    <a-cr>RDTIME</a-cr><a-p>,</a-p>
    <a-cr>RDINSTRET</a-cr><a-p>,</a-p>
<a-p>}</a-p></pre>
<p>And implement traits <code>Display</code> and <code>Opcode</code>.</p>
<pre class="language-rust"><a-k>impl</a-k> <a-t>Display</a-t> <a-k>for</a-k> <a-t>ZicntrOpcode</a-t> <a-p>{</a-p>
    <a-k>fn</a-k> <a-f>fmt</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-v>self</a-v><a-p>,</a-p> <a-v>f</a-v><a-p>:</a-p> <a-o>&amp;</a-o><a-k>mut</a-k> <a-t>Formatter</a-t><a-p>)</a-p> -&gt; fmt<a-p>::</a-p><a-t>Result</a-t> <a-p>{</a-p>
        <a-k>match</a-k> <a-v>self</a-v> <a-p>{</a-p>
            <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE_H</a-cr> =&gt; <a-m>write!</a-m><a-p>(</a-p>f<a-p>,</a-p> <a-s>&quot;rdcycleh&quot;</a-s><a-p>),</a-p>
            <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME_H</a-cr> =&gt; <a-m>write!</a-m><a-p>(</a-p>f<a-p>,</a-p> <a-s>&quot;rdtimeh&quot;</a-s><a-p>),</a-p>
            <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET_H</a-cr> =&gt; <a-m>write!</a-m><a-p>(</a-p>f<a-p>,</a-p> <a-s>&quot;rdinstreth&quot;</a-s><a-p>),</a-p>
            <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE</a-cr> =&gt; <a-m>write!</a-m><a-p>(</a-p>f<a-p>,</a-p> <a-s>&quot;rdcycle&quot;</a-s><a-p>),</a-p>
            <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr> =&gt; <a-m>write!</a-m><a-p>(</a-p>f<a-p>,</a-p> <a-s>&quot;rdtime&quot;</a-s><a-p>),</a-p>
            <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET</a-cr> =&gt; <a-m>write!</a-m><a-p>(</a-p>f<a-p>,</a-p> <a-s>&quot;rdinstret&quot;</a-s><a-p>),</a-p>
        <a-p>}</a-p>
    <a-p>}</a-p>
<a-p>}</a-p>

<a-k>impl</a-k> <a-t>Opcode</a-t> <a-k>for</a-k> <a-t>ZicntrOpcode</a-t> <a-p>{</a-p>
    <a-k>fn</a-k> <a-f>get_format</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-v>self</a-v><a-p>)</a-p> -&gt; <a-t>InstFormat</a-t> <a-p>{</a-p>
        <a-k>match</a-k> <a-v>self</a-v> <a-p>{</a-p>
            <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE_H</a-cr>
            | <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME_H</a-cr>
            | <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET_H</a-cr>
            | <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE</a-cr>
            | <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr>
            | <a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET</a-cr> =&gt; <a-t>InstFormat</a-t><a-p>::</a-p><a-cr>CSRcntrformat</a-cr><a-p>,</a-p>
        <a-p>}</a-p>
    <a-p>}</a-p>
<a-p>}</a-p></pre>
<p>In this case, there are no appropriate exising format.<br />
Thus, I added new format to <code>InstFormat</code>.</p>
<h3>Implement decoding.</h3>
<p>Since the instruction to be added is a 32-bit instruction (not compressed), add the file to the following directory.</p>
<pre class="language-bash"><a-f>any_editor_command</a-f> src/decode/inst_32/zicntr_extension.rs</pre>
<pre class="language-rust"><a-k>pub</a-k> <a-k>fn</a-k> <a-f>parse_opcode</a-f><a-p>(</a-p><a-v>inst</a-v><a-p>:</a-p> <a-t>u32</a-t><a-p>)</a-p> -&gt; <a-t>Result</a-t><a-p>&lt;</a-p><a-t>ZicntrOpcode</a-t><a-p>,</a-p> <a-t>DecodingError</a-t><a-p>&gt;</a-p> <a-p>{</a-p>
    <a-k>let</a-k> opmap<a-p>:</a-p> <a-t>u8</a-t> = u8<a-p>::</a-p><a-f>try_from</a-f><a-p>(</a-p>inst<a-p>.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>6</a-co><a-p>,</a-p> <a-co>0</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p>
    <a-k>let</a-k> funct3<a-p>:</a-p> <a-t>u8</a-t> = u8<a-p>::</a-p><a-f>try_from</a-f><a-p>(</a-p>inst<a-p>.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>14</a-co><a-p>,</a-p> <a-co>12</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p>
    <a-k>let</a-k> csr_num<a-p>:</a-p> <a-t>u16</a-t> = u16<a-p>::</a-p><a-f>try_from</a-f><a-p>(</a-p>inst<a-p>.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>20</a-co><a-p>,</a-p> <a-co>31</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p>

    <a-k>match</a-k> opmap <a-p>{</a-p>
        <a-co>0b111_0011</a-co> =&gt; <a-k>match</a-k> funct3 <a-p>{</a-p>
            <a-co>0b010</a-co> =&gt; <a-k>match</a-k> csr_num <a-p>{</a-p>
                <a-co>0xc00</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE</a-cr><a-p>),</a-p>
                <a-co>0xc01</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr><a-p>),</a-p>
                <a-co>0xc02</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET</a-cr><a-p>),</a-p>
                <a-co>0xc80</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE_H</a-cr><a-p>),</a-p>
                <a-co>0xc81</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME_H</a-cr><a-p>),</a-p>
                <a-co>0xc82</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET_H</a-cr><a-p>),</a-p>
                _ =&gt; <a-f>Err</a-f><a-p>(</a-p><a-t>DecodingError</a-t><a-p>::</a-p><a-cr>InvalidOpcode</a-cr><a-p>),</a-p>
            <a-p>},</a-p>
            _ =&gt; <a-f>Err</a-f><a-p>(</a-p><a-t>DecodingError</a-t><a-p>::</a-p><a-cr>InvalidFunct3</a-cr><a-p>),</a-p>
        <a-p>},</a-p>
        _ =&gt; <a-f>Err</a-f><a-p>(</a-p><a-t>DecodingError</a-t><a-p>::</a-p><a-cr>InvalidOpcode</a-cr><a-p>),</a-p>
    <a-p>}</a-p>
<a-p>}</a-p>
..<a-p>.</a-p></pre>
<h3>Add extension definition</h3>
<p>Add extension definition to lib.rs</p>
<pre class="language-rust"><a-c>/// RISC-V extensions
</a-c><a-at>#</a-at><a-p>[</a-p><a-at>derive</a-at><a-p>(</a-p><a-cr>Debug</a-cr><a-p>)]</a-p>
<a-k>enum</a-k> <a-t>Extensions</a-t> <a-p>{</a-p>
    <a-c>/// Base Integer Instruction Set
</a-c>    <a-cr>BaseI</a-cr><a-p>,</a-p>
    <a-c>/// Integer Multiplication and Division
</a-c>    <a-cr>M</a-cr><a-p>,</a-p>
    <a-c>/// Atomic Instructions
</a-c>    <a-cr>A</a-cr><a-p>,</a-p>
    <a-c>/// Compressed Instructions
</a-c>    <a-cr>C</a-cr><a-p>,</a-p>
    <a-c>/// Instruction-Fetch Fence
</a-c>    <a-cr>Zifencei</a-cr><a-p>,</a-p>
    <a-c>/// Control and Status Register Instructions
</a-c>    <a-cr>Zicsr</a-cr><a-p>,</a-p>
    <a-c>/// Base Counters and Timers
</a-c>    <a-cr>Zicntr</a-cr><a-p>,</a-p>
    <a-c>/// Privileged Instructions
</a-c>    <a-cr>Priv</a-cr><a-p>,</a-p>
<a-p>}</a-p></pre>
<p>and add to <code>OpcodeKind</code>.</p>
<pre class="language-rust"><a-c>/// Extension type and Instruction name.
</a-c><a-at>#</a-at><a-p>[</a-p><a-at>derive</a-at><a-p>(</a-p><a-cr>Debug</a-cr><a-p>,</a-p><a-at> </a-at><a-cr>PartialEq</a-cr><a-p>)]</a-p>
<a-k>pub</a-k> <a-k>enum</a-k> <a-t>OpcodeKind</a-t> <a-p>{</a-p>
    <a-c>/// Base Integer Instruction Set
</a-c>    <a-cr>BaseI</a-cr><a-p>(</a-p><a-t>BaseIOpcode</a-t><a-p>),</a-p>
    <a-c>/// Integer Multiplication and Division
</a-c>    <a-cr>M</a-cr><a-p>(</a-p><a-t>MOpcode</a-t><a-p>),</a-p>
    <a-c>/// Atomic Instructions
</a-c>    <a-cr>A</a-cr><a-p>(</a-p><a-t>AOpcode</a-t><a-p>),</a-p>
    <a-c>/// Compressed Instructions
</a-c>    <a-cr>C</a-cr><a-p>(</a-p><a-t>COpcode</a-t><a-p>),</a-p>
    <a-c>/// Instruction-Fetch Fence,
</a-c>    <a-cr>Zifencei</a-cr><a-p>(</a-p><a-t>ZifenceiOpcode</a-t><a-p>),</a-p>
    <a-c>/// Control and Status Register Instructions
</a-c>    <a-cr>Zicsr</a-cr><a-p>(</a-p><a-t>ZicsrOpcode</a-t><a-p>),</a-p>
    <a-c>/// Base Counters and Timers
</a-c>    <a-cr>Zicntr</a-cr><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>),</a-p>
    <a-c>/// Privileged Instructions
</a-c>    <a-cr>Priv</a-cr><a-p>(</a-p><a-t>PrivOpcode</a-t><a-p>),</a-p>
<a-p>}</a-p></pre>
<h3>Add match pattern to Decode trait functions</h3>
<p>When you add the extension definitions, you'll see that error occur that don't cover patterns in the <code>Decode</code> trait.</p>
<pre class="language-diff"> fn parse_opcode(self, isa: Isa) -&gt; Result&lt;OpcodeKind, DecodingError&gt; {
     let extension = self.parse_extension();
 
     match extension {
         Ok(Extensions::BaseI) =&gt; Ok(OpcodeKind::BaseI(base_i::parse_opcode(self, isa)?)),
         Ok(Extensions::M) =&gt; Ok(OpcodeKind::M(m_extension::parse_opcode(self, isa)?)),
         Ok(Extensions::A) =&gt; Ok(OpcodeKind::A(a_extension::parse_opcode(self, isa)?)),
         Ok(Extensions::Zifencei) =&gt; Ok(OpcodeKind::Zifencei(zifencei_extension::parse_opcode(
             self,
         )?)),
         Ok(Extensions::Zicsr) =&gt; Ok(OpcodeKind::Zicsr(zicsr_extension::parse_opcode(self)?)),
<a-s>+        Ok(Extensions::Zicntr) =&gt; Ok(OpcodeKind::Zicntr(zicntr_extension::parse_opcode(self)?)),</a-s>
         Ok(Extensions::Priv) =&gt; Ok(OpcodeKind::Priv(priv_extension::parse_opcode(self)?)),
         Ok(Extensions::C) =&gt; Err(DecodingError::Not32BitInst),
         Err(decoding_err) =&gt; Err(decoding_err),
     }
 }
 ...</pre>
<h3>Implement extension parsing</h3>
<p>The parse_extension is used to determine which extension the instruction belongs to.</p>
<pre class="language-rust"><a-k>fn</a-k> <a-f>parse_extension</a-f><a-p>(</a-p><a-v>self</a-v><a-p>)</a-p> -&gt; <a-t>Result</a-t><a-p>&lt;</a-p><a-t>Extensions</a-t><a-p>,</a-p> <a-t>DecodingError</a-t><a-p>&gt;</a-p> <a-p>{</a-p>
    <a-c>// ...</a-c>
    <a-k>let</a-k> csr<a-p>:</a-p> <a-t>u16</a-t> = u16<a-p>::</a-p><a-f>try_from</a-f><a-p>(</a-p><a-v>self</a-v><a-p>.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>31</a-co><a-p>,</a-p> <a-co>20</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p>

    <a-k>match</a-k> opmap <a-p>{</a-p>
        <a-c>// ...</a-c>
        <a-co>0b111_0011</a-co> =&gt; <a-k>match</a-k> funct3 <a-p>{</a-p>
            <a-co>0b000</a-co> =&gt; <a-k>match</a-k> funct7 <a-p>{</a-p>
                <a-co>0b000_0000</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>BaseI</a-cr><a-p>),</a-p>
                _ =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Priv</a-cr><a-p>),</a-p>
            <a-p>},</a-p>
            <a-co>0b010</a-co> =&gt; <a-k>match</a-k> csr <a-p>{</a-p>
                <a-c>// csrrs rd, (cycle|time|instret), zero</a-c>
                <a-co>0xc00</a-co>..=<a-co>0xc02</a-co> | <a-co>0xc80</a-co>..=<a-co>0xc82</a-co> =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Zicntr</a-cr><a-p>),</a-p>
                _ =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Zicsr</a-cr><a-p>),</a-p>
            <a-p>},</a-p>
            _ =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Zicsr</a-cr><a-p>),</a-p>
        <a-p>},</a-p>
        _ =&gt; <a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>BaseI</a-cr><a-p>),</a-p>
    <a-p>}</a-p>
<a-p>}</a-p></pre>
<h3>Re-export</h3>
<p>Don't forget to re-export the definition in lib.rs (I forgot to include it to example branch).</p>
<pre class="language-rust"><a-c>// re-export definition</a-c>
<a-k>pub</a-k> <a-k>use</a-k> <a-k>crate</a-k><a-p>::</a-p>instruction<a-p>::{</a-p>
    a_extension<a-p>::</a-p><a-cr>AOpcode</a-cr><a-p>,</a-p> base_i<a-p>::</a-p><a-cr>BaseIOpcode</a-cr><a-p>,</a-p> c_extension<a-p>::</a-p><a-cr>COpcode</a-cr><a-p>,</a-p> m_extension<a-p>::</a-p><a-cr>MOpcode</a-cr><a-p>,</a-p>
    priv_extension<a-p>::</a-p><a-cr>PrivOpcode</a-cr><a-p>,</a-p> zicsr_extension<a-p>::</a-p><a-cr>ZicsrOpcode</a-cr><a-p>,</a-p> zifencei_extension<a-p>::</a-p><a-cr>ZifenceiOpcode</a-cr><a-p>,</a-p>
    <a-cr>InstFormat</a-cr><a-p>,</a-p> <a-cr>Instruction</a-cr><a-p>,</a-p> <a-cr>OpcodeKind</a-cr><a-p>,</a-p>
<a-p>};</a-p></pre>
<h3>Add unit tests.</h3>
<p>Add unit tests to decode/inst_32/xxx_extension.rs.</p>
<pre class="language-rust"><a-at>#</a-at><a-p>[</a-p><a-at>cfg</a-at><a-p>(</a-p><a-at>test</a-at><a-p>)]</a-p>
<a-at>#</a-at><a-p>[</a-p><a-at>allow</a-at><a-p>(</a-p><a-at>unused_variables</a-at><a-p>)]</a-p>
<a-k>mod</a-k> test_zicntr <a-p>{</a-p>
    <a-at>#</a-at><a-p>[</a-p><a-at>test</a-at><a-p>]</a-p>
    <a-at>#</a-at><a-p>[</a-p><a-at>allow</a-at><a-p>(</a-p><a-at>overflowing_literals</a-at><a-p>)]</a-p>
    <a-k>fn</a-k> <a-f>zicntr_decode_test</a-f><a-p>()</a-p> <a-p>{</a-p>
        <a-k>use</a-k> <a-k>super</a-k><a-p>::</a-p><a-o>*</a-o><a-p>;</a-p>
        <a-k>use</a-k> <a-k>crate</a-k><a-p>::{</a-p><a-cr>Decode</a-cr><a-p>,</a-p> <a-cr>Isa</a-cr><a-p>,</a-p> <a-cr>OpcodeKind</a-cr><a-p>};</a-p>

        <a-k>let</a-k> test_32 = |<a-v>inst_32</a-v><a-p>:</a-p> <a-t>u32</a-t><a-p>,</a-p>
                       <a-v>op</a-v><a-p>:</a-p> <a-t>OpcodeKind</a-t><a-p>,</a-p>
                       <a-v>rd</a-v><a-p>:</a-p> <a-t>Option</a-t><a-p>&lt;</a-p><a-t>usize</a-t><a-p>&gt;,</a-p>
                       <a-v>rs1</a-v><a-p>:</a-p> <a-t>Option</a-t><a-p>&lt;</a-p><a-t>usize</a-t><a-p>&gt;,</a-p>
                       <a-v>rs2</a-v><a-p>:</a-p> <a-t>Option</a-t><a-p>&lt;</a-p><a-t>usize</a-t><a-p>&gt;,</a-p>
                       <a-v>imm</a-v><a-p>:</a-p> <a-t>Option</a-t><a-p>&lt;</a-p><a-t>i32</a-t><a-p>&gt;</a-p>| <a-p>{</a-p>
            <a-k>let</a-k> op_32 = inst_32<a-p>.</a-p><a-f>parse_opcode</a-f><a-p>(</a-p><a-t>Isa</a-t><a-p>::</a-p><a-cr>Rv64</a-cr><a-p>).</a-p><a-f>unwrap</a-f><a-p>();</a-p>
            <a-m>assert!</a-m><a-p>(</a-p><a-m>matches!</a-m><a-p>(</a-p><a-o>&amp;</a-o>op_32<a-p>,</a-p> op<a-p>));</a-p>
            <a-m>assert_eq!</a-m><a-p>(</a-p>inst_32<a-p>.</a-p><a-f>parse_rd</a-f><a-p>(</a-p><a-o>&amp;</a-o>op_32<a-p>).</a-p><a-f>unwrap</a-f><a-p>(),</a-p> rd<a-p>);</a-p>
            <a-m>assert_eq!</a-m><a-p>(</a-p>inst_32<a-p>.</a-p><a-f>parse_rs1</a-f><a-p>(</a-p><a-o>&amp;</a-o>op_32<a-p>).</a-p><a-f>unwrap</a-f><a-p>(),</a-p> rs1<a-p>);</a-p>
            <a-m>assert_eq!</a-m><a-p>(</a-p>inst_32<a-p>.</a-p><a-f>parse_rs2</a-f><a-p>(</a-p><a-o>&amp;</a-o>op_32<a-p>).</a-p><a-f>unwrap</a-f><a-p>(),</a-p> rs2<a-p>);</a-p>
            <a-m>assert_eq!</a-m><a-p>(</a-p>inst_32<a-p>.</a-p><a-f>parse_imm</a-f><a-p>(</a-p><a-o>&amp;</a-o>op_32<a-p>,</a-p> <a-t>Isa</a-t><a-p>::</a-p><a-cr>Rv64</a-cr><a-p>).</a-p><a-f>unwrap</a-f><a-p>(),</a-p> imm<a-p>);</a-p>
        <a-p>};</a-p>

        <a-f>test_32</a-f><a-p>(</a-p>
            <a-co>0b1100_0000_0001_0000_0010_0111_1111_0011</a-co><a-p>,</a-p>
            <a-t>OpcodeKind</a-t><a-p>::</a-p><a-f>Zicntr</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr><a-p>),</a-p>
            <a-f>Some</a-f><a-p>(</a-p><a-co>15</a-co><a-p>),</a-p>
            <a-cr>None</a-cr><a-p>,</a-p>
            <a-cr>None</a-cr><a-p>,</a-p>
            <a-cr>None</a-cr><a-p>,</a-p>
        <a-p>)</a-p>
    <a-p>}</a-p>
<a-p>}</a-p></pre>
<h3>Address clippy warnings</h3>
<pre>$ cargo clippy # pedantic is enable by default.
</pre>
</section><div class="code-panel"><pre class="code src language-markdown"><span class="code-line"><a class="ln" id="L1" href="#L1">1</a><span class="code-text"><a-p>#</a-p> <a-tt>Contribution Guide</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L2" href="#L2">2</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L3" href="#L3">3</a><span class="code-text"><a-p>##</a-p> <a-tt>What can I do?</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L4" href="#L4">4</a><span class="code-text">Any contribution is welcome.</span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L5" href="#L5">5</a><span class="code-text"><a-p>- </a-p>Correction typo in document.</span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L6" href="#L6">6</a><span class="code-text"><a-p>- </a-p>Pull request for new extension supporting</span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L7" href="#L7">7</a><span class="code-text"><a-p>- </a-p>Point out the lack of API</span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L8" href="#L8">8</a><span class="code-text"><a-p>- </a-p>Correction of English expressions (If you are better at English than DeepL, here&#39;s your chance to be a contributor!)</span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L9" href="#L9">9</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L10" href="#L10">10</a><span class="code-text"><a-p>## </a-p><a-tt>How to add a supporting extension?</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L11" href="#L11">11</a><span class="code-text"><a-p>Zicntr extension as an example.  </a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L12" href="#L12">12</a><span class="code-text"><a-p>See: [https://github.com/Alignof/raki/pull/16](https://github.com/Alignof/raki/pull/16)</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L13" href="#L13">13</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L14" href="#L14">14</a><span class="code-text"><a-p>### </a-p><a-tt>Add the definition of an instruction</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L15" href="#L15">15</a><span class="code-text"><a-p>First, list the instructions that the extension has in an Enum.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L16" href="#L16">16</a><span class="code-text"><a-p>```</a-p><a-tl>sh</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L17" href="#L17">17</a><span class="code-text"><a-p>any_editor_command src/instruction/zicntr_extension.rs</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L18" href="#L18">18</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L19" href="#L19">19</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L20" href="#L20">20</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L21" href="#L21">21</a><span class="code-text"><a-p>/// Insturctions in Zicntr Extension.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L22" href="#L22">22</a><span class="code-text"><a-p>#[allow(non_camel_case_types)]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L23" href="#L23">23</a><span class="code-text"><a-p>#[derive(</a-p><a-cr>Debug</a-cr><a-p>, </a-p><a-cr>PartialEq</a-cr><a-p>)]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L24" href="#L24">24</a><span class="code-text"><a-p>pub </a-p><a-k>enum</a-k><a-p> </a-p><a-t>ZicntrOpcode</a-t><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L25" href="#L25">25</a><span class="code-text"><a-p>    </a-p><a-c>// For Rv32, these instructions indicate lower 32 bits.</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L26" href="#L26">26</a><span class="code-text"><a-p>    </a-p><a-c>// For Rv64, these instructions do not exist.</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L27" href="#L27">27</a><span class="code-text"><a-p>    </a-p><a-cr>RDCYCLE_H</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L28" href="#L28">28</a><span class="code-text"><a-p>    </a-p><a-cr>RDTIME_H</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L29" href="#L29">29</a><span class="code-text"><a-p>    </a-p><a-cr>RDINSTRET_H</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L30" href="#L30">30</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L31" href="#L31">31</a><span class="code-text"><a-p>    </a-p><a-c>// For Rv32, these instructions indicate upper 32 bits.</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L32" href="#L32">32</a><span class="code-text"><a-p>    </a-p><a-c>// For Rv64, these instructions can access the full 64-bit CSRs directly.</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L33" href="#L33">33</a><span class="code-text"><a-p>    </a-p><a-cr>RDCYCLE</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L34" href="#L34">34</a><span class="code-text"><a-p>    </a-p><a-cr>RDTIME</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L35" href="#L35">35</a><span class="code-text"><a-p>    </a-p><a-cr>RDINSTRET</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L36" href="#L36">36</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L37" href="#L37">37</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L38" href="#L38">38</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L39" href="#L39">39</a><span class="code-text"><a-p>And implement traits `Display` and `Opcode`.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L40" href="#L40">40</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L41" href="#L41">41</a><span class="code-text"><a-p>impl </a-p><a-t>Display</a-t><a-p> </a-p><a-k>for</a-k><a-p> </a-p><a-t>ZicntrOpcode</a-t><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L42" href="#L42">42</a><span class="code-text"><a-p>    </a-p><a-k>fn</a-k><a-p> </a-p><a-f>fmt</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-v>self</a-v><a-p>, </a-p><a-v>f</a-v><a-p>: </a-p><a-o>&amp;</a-o><a-k>mut</a-k><a-p> </a-p><a-t>Formatter</a-t><a-p>) -&gt; fmt::</a-p><a-t>Result</a-t><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L43" href="#L43">43</a><span class="code-text"><a-p>        </a-p><a-k>match</a-k><a-p> </a-p><a-v>self</a-v><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L44" href="#L44">44</a><span class="code-text"><a-p>            </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE_H</a-cr><a-p> =&gt; </a-p><a-m>write!</a-m><a-p>(f, </a-p><a-s>&quot;rdcycleh&quot;</a-s><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L45" href="#L45">45</a><span class="code-text"><a-p>            </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME_H</a-cr><a-p> =&gt; </a-p><a-m>write!</a-m><a-p>(f, </a-p><a-s>&quot;rdtimeh&quot;</a-s><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L46" href="#L46">46</a><span class="code-text"><a-p>            </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET_H</a-cr><a-p> =&gt; </a-p><a-m>write!</a-m><a-p>(f, </a-p><a-s>&quot;rdinstreth&quot;</a-s><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L47" href="#L47">47</a><span class="code-text"><a-p>            </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE</a-cr><a-p> =&gt; </a-p><a-m>write!</a-m><a-p>(f, </a-p><a-s>&quot;rdcycle&quot;</a-s><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L48" href="#L48">48</a><span class="code-text"><a-p>            </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr><a-p> =&gt; </a-p><a-m>write!</a-m><a-p>(f, </a-p><a-s>&quot;rdtime&quot;</a-s><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L49" href="#L49">49</a><span class="code-text"><a-p>            </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET</a-cr><a-p> =&gt; </a-p><a-m>write!</a-m><a-p>(f, </a-p><a-s>&quot;rdinstret&quot;</a-s><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L50" href="#L50">50</a><span class="code-text"><a-p>        }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L51" href="#L51">51</a><span class="code-text"><a-p>    }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L52" href="#L52">52</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L53" href="#L53">53</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L54" href="#L54">54</a><span class="code-text"><a-p>impl </a-p><a-t>Opcode</a-t><a-p> </a-p><a-k>for</a-k><a-p> </a-p><a-t>ZicntrOpcode</a-t><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L55" href="#L55">55</a><span class="code-text"><a-p>    </a-p><a-k>fn</a-k><a-p> </a-p><a-f>get_format</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-v>self</a-v><a-p>) -&gt; </a-p><a-t>InstFormat</a-t><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L56" href="#L56">56</a><span class="code-text"><a-p>        </a-p><a-k>match</a-k><a-p> </a-p><a-v>self</a-v><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L57" href="#L57">57</a><span class="code-text"><a-p>            </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE_H</a-cr></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L58" href="#L58">58</a><span class="code-text"><a-p>            | </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME_H</a-cr></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L59" href="#L59">59</a><span class="code-text"><a-p>            | </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET_H</a-cr></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L60" href="#L60">60</a><span class="code-text"><a-p>            | </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE</a-cr></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L61" href="#L61">61</a><span class="code-text"><a-p>            | </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L62" href="#L62">62</a><span class="code-text"><a-p>            | </a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET</a-cr><a-p> =&gt; </a-p><a-t>InstFormat</a-t><a-p>::</a-p><a-cr>CSRcntrformat</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L63" href="#L63">63</a><span class="code-text"><a-p>        }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L64" href="#L64">64</a><span class="code-text"><a-p>    }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L65" href="#L65">65</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L66" href="#L66">66</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L67" href="#L67">67</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L68" href="#L68">68</a><span class="code-text"><a-p>In this case, there are no appropriate exising format.  </a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L69" href="#L69">69</a><span class="code-text"><a-p>Thus, I added new format to `InstFormat`.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L70" href="#L70">70</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L71" href="#L71">71</a><span class="code-text"><a-p>### </a-p><a-tt>Implement decoding.</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L72" href="#L72">72</a><span class="code-text"><a-p>Since the instruction to be added is a 32-bit instruction (not compressed), add the file to the following directory.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L73" href="#L73">73</a><span class="code-text"><a-p>```</a-p><a-tl>sh</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L74" href="#L74">74</a><span class="code-text"><a-p>any_editor_command src/decode/inst_32/zicntr_extension.rs</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L75" href="#L75">75</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L76" href="#L76">76</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L77" href="#L77">77</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L78" href="#L78">78</a><span class="code-text"><a-p>pub </a-p><a-k>fn</a-k><a-p> </a-p><a-f>parse_opcode</a-f><a-p>(</a-p><a-v>inst</a-v><a-p>: </a-p><a-t>u32</a-t><a-p>) -&gt; </a-p><a-t>Result</a-t><a-p>&lt;</a-p><a-t>ZicntrOpcode</a-t><a-p>, </a-p><a-t>DecodingError</a-t><a-p>&gt; {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L79" href="#L79">79</a><span class="code-text"><a-p>    </a-p><a-k>let</a-k><a-p> opmap: </a-p><a-t>u8</a-t><a-p> = u8::</a-p><a-f>try_from</a-f><a-p>(inst.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>6</a-co><a-p>, </a-p><a-co>0</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L80" href="#L80">80</a><span class="code-text"><a-p>    </a-p><a-k>let</a-k><a-p> funct3: </a-p><a-t>u8</a-t><a-p> = u8::</a-p><a-f>try_from</a-f><a-p>(inst.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>14</a-co><a-p>, </a-p><a-co>12</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L81" href="#L81">81</a><span class="code-text"><a-p>    </a-p><a-k>let</a-k><a-p> csr_num: </a-p><a-t>u16</a-t><a-p> = u16::</a-p><a-f>try_from</a-f><a-p>(inst.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>20</a-co><a-p>, </a-p><a-co>31</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L82" href="#L82">82</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L83" href="#L83">83</a><span class="code-text"><a-p>    </a-p><a-k>match</a-k><a-p> opmap {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L84" href="#L84">84</a><span class="code-text"><a-p>        </a-p><a-co>0b111_0011</a-co><a-p> =&gt; </a-p><a-k>match</a-k><a-p> funct3 {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L85" href="#L85">85</a><span class="code-text"><a-p>            </a-p><a-co>0b010</a-co><a-p> =&gt; </a-p><a-k>match</a-k><a-p> csr_num {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L86" href="#L86">86</a><span class="code-text"><a-p>                </a-p><a-co>0xc00</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L87" href="#L87">87</a><span class="code-text"><a-p>                </a-p><a-co>0xc01</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L88" href="#L88">88</a><span class="code-text"><a-p>                </a-p><a-co>0xc02</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L89" href="#L89">89</a><span class="code-text"><a-p>                </a-p><a-co>0xc80</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDCYCLE_H</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L90" href="#L90">90</a><span class="code-text"><a-p>                </a-p><a-co>0xc81</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME_H</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L91" href="#L91">91</a><span class="code-text"><a-p>                </a-p><a-co>0xc82</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDINSTRET_H</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L92" href="#L92">92</a><span class="code-text"><a-p>                _ =&gt; </a-p><a-f>Err</a-f><a-p>(</a-p><a-t>DecodingError</a-t><a-p>::</a-p><a-cr>InvalidOpcode</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L93" href="#L93">93</a><span class="code-text"><a-p>            },</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L94" href="#L94">94</a><span class="code-text"><a-p>            _ =&gt; </a-p><a-f>Err</a-f><a-p>(</a-p><a-t>DecodingError</a-t><a-p>::</a-p><a-cr>InvalidFunct3</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L95" href="#L95">95</a><span class="code-text"><a-p>        },</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L96" href="#L96">96</a><span class="code-text"><a-p>        _ =&gt; </a-p><a-f>Err</a-f><a-p>(</a-p><a-t>DecodingError</a-t><a-p>::</a-p><a-cr>InvalidOpcode</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L97" href="#L97">97</a><span class="code-text"><a-p>    }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L98" href="#L98">98</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L99" href="#L99">99</a><span class="code-text"><a-p>...</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L100" href="#L100">100</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L101" href="#L101">101</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L102" href="#L102">102</a><span class="code-text"><a-p>### </a-p><a-tt>Add extension definition</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L103" href="#L103">103</a><span class="code-text"><a-p>Add extension definition to lib.rs</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L104" href="#L104">104</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L105" href="#L105">105</a><span class="code-text"><a-p>/// RISC-V extensions</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L106" href="#L106">106</a><span class="code-text"><a-p>#[derive(</a-p><a-cr>Debug</a-cr><a-p>)]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L107" href="#L107">107</a><span class="code-text"><a-p>enum </a-p><a-t>Extensions</a-t><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L108" href="#L108">108</a><span class="code-text"><a-p>    </a-p><a-c>/// Base Integer Instruction Set</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L109" href="#L109">109</a><span class="code-text"><a-p>    </a-p><a-cr>BaseI</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L110" href="#L110">110</a><span class="code-text"><a-p>    </a-p><a-c>/// Integer Multiplication and Division</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L111" href="#L111">111</a><span class="code-text"><a-p>    </a-p><a-cr>M</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L112" href="#L112">112</a><span class="code-text"><a-p>    </a-p><a-c>/// Atomic Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L113" href="#L113">113</a><span class="code-text"><a-p>    </a-p><a-cr>A</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L114" href="#L114">114</a><span class="code-text"><a-p>    </a-p><a-c>/// Compressed Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L115" href="#L115">115</a><span class="code-text"><a-p>    </a-p><a-cr>C</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L116" href="#L116">116</a><span class="code-text"><a-p>    </a-p><a-c>/// Instruction-Fetch Fence</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L117" href="#L117">117</a><span class="code-text"><a-p>    </a-p><a-cr>Zifencei</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L118" href="#L118">118</a><span class="code-text"><a-p>    </a-p><a-c>/// Control and Status Register Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L119" href="#L119">119</a><span class="code-text"><a-p>    </a-p><a-cr>Zicsr</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L120" href="#L120">120</a><span class="code-text"><a-p>    </a-p><a-c>/// Base Counters and Timers</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L121" href="#L121">121</a><span class="code-text"><a-p>    </a-p><a-cr>Zicntr</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L122" href="#L122">122</a><span class="code-text"><a-p>    </a-p><a-c>/// Privileged Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L123" href="#L123">123</a><span class="code-text"><a-p>    </a-p><a-cr>Priv</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L124" href="#L124">124</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L125" href="#L125">125</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L126" href="#L126">126</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L127" href="#L127">127</a><span class="code-text"><a-p>and add to `OpcodeKind`.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L128" href="#L128">128</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L129" href="#L129">129</a><span class="code-text"><a-p>/// Extension type and Instruction name.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L130" href="#L130">130</a><span class="code-text"><a-p>#[derive(</a-p><a-cr>Debug</a-cr><a-p>, </a-p><a-cr>PartialEq</a-cr><a-p>)]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L131" href="#L131">131</a><span class="code-text"><a-p>pub </a-p><a-k>enum</a-k><a-p> </a-p><a-t>OpcodeKind</a-t><a-p> {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L132" href="#L132">132</a><span class="code-text"><a-p>    </a-p><a-c>/// Base Integer Instruction Set</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L133" href="#L133">133</a><span class="code-text"><a-p>    </a-p><a-cr>BaseI</a-cr><a-p>(</a-p><a-t>BaseIOpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L134" href="#L134">134</a><span class="code-text"><a-p>    </a-p><a-c>/// Integer Multiplication and Division</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L135" href="#L135">135</a><span class="code-text"><a-p>    </a-p><a-cr>M</a-cr><a-p>(</a-p><a-t>MOpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L136" href="#L136">136</a><span class="code-text"><a-p>    </a-p><a-c>/// Atomic Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L137" href="#L137">137</a><span class="code-text"><a-p>    </a-p><a-cr>A</a-cr><a-p>(</a-p><a-t>AOpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L138" href="#L138">138</a><span class="code-text"><a-p>    </a-p><a-c>/// Compressed Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L139" href="#L139">139</a><span class="code-text"><a-p>    </a-p><a-cr>C</a-cr><a-p>(</a-p><a-t>COpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L140" href="#L140">140</a><span class="code-text"><a-p>    </a-p><a-c>/// Instruction-Fetch Fence,</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L141" href="#L141">141</a><span class="code-text"><a-p>    </a-p><a-cr>Zifencei</a-cr><a-p>(</a-p><a-t>ZifenceiOpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L142" href="#L142">142</a><span class="code-text"><a-p>    </a-p><a-c>/// Control and Status Register Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L143" href="#L143">143</a><span class="code-text"><a-p>    </a-p><a-cr>Zicsr</a-cr><a-p>(</a-p><a-t>ZicsrOpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L144" href="#L144">144</a><span class="code-text"><a-p>    </a-p><a-c>/// Base Counters and Timers</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L145" href="#L145">145</a><span class="code-text"><a-p>    </a-p><a-cr>Zicntr</a-cr><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L146" href="#L146">146</a><span class="code-text"><a-p>    </a-p><a-c>/// Privileged Instructions</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L147" href="#L147">147</a><span class="code-text"><a-p>    </a-p><a-cr>Priv</a-cr><a-p>(</a-p><a-t>PrivOpcode</a-t><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L148" href="#L148">148</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L149" href="#L149">149</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L150" href="#L150">150</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L151" href="#L151">151</a><span class="code-text"><a-p>### </a-p><a-tt>Add match pattern to Decode trait functions</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L152" href="#L152">152</a><span class="code-text"><a-p>When you add the extension definitions, you&#39;ll see that error occur that don&#39;t cover patterns in the `Decode` trait.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L153" href="#L153">153</a><span class="code-text"><a-p>```</a-p><a-tl>diff</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L154" href="#L154">154</a><span class="code-text"><a-p> fn parse_opcode(self, isa: Isa) -&gt; Result&lt;OpcodeKind, DecodingError&gt; {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L155" href="#L155">155</a><span class="code-text"><a-p>     let extension = self.parse_extension();</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L156" href="#L156">156</a><span class="code-text"><a-p> </a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L157" href="#L157">157</a><span class="code-text"><a-p>     match extension {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L158" href="#L158">158</a><span class="code-text"><a-p>         Ok(Extensions::BaseI) =&gt; Ok(OpcodeKind::BaseI(base_i::parse_opcode(self, isa)?)),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L159" href="#L159">159</a><span class="code-text"><a-p>         Ok(Extensions::M) =&gt; Ok(OpcodeKind::M(m_extension::parse_opcode(self, isa)?)),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L160" href="#L160">160</a><span class="code-text"><a-p>         Ok(Extensions::A) =&gt; Ok(OpcodeKind::A(a_extension::parse_opcode(self, isa)?)),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L161" href="#L161">161</a><span class="code-text"><a-p>         Ok(Extensions::Zifencei) =&gt; Ok(OpcodeKind::Zifencei(zifencei_extension::parse_opcode(</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L162" href="#L162">162</a><span class="code-text"><a-p>             self,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L163" href="#L163">163</a><span class="code-text"><a-p>         )?)),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L164" href="#L164">164</a><span class="code-text"><a-p>         Ok(Extensions::Zicsr) =&gt; Ok(OpcodeKind::Zicsr(zicsr_extension::parse_opcode(self)?)),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L165" href="#L165">165</a><span class="code-text"><a-p>+        Ok(Extensions::Zicntr) =&gt; Ok(OpcodeKind::Zicntr(zicntr_extension::parse_opcode(self)?)),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L166" href="#L166">166</a><span class="code-text"><a-p>         Ok(Extensions::Priv) =&gt; Ok(OpcodeKind::Priv(priv_extension::parse_opcode(self)?)),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L167" href="#L167">167</a><span class="code-text"><a-p>         Ok(Extensions::C) =&gt; Err(DecodingError::Not32BitInst),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L168" href="#L168">168</a><span class="code-text"><a-p>         Err(decoding_err) =&gt; Err(decoding_err),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L169" href="#L169">169</a><span class="code-text"><a-p>     }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L170" href="#L170">170</a><span class="code-text"><a-p> }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L171" href="#L171">171</a><span class="code-text"><a-p> ...</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L172" href="#L172">172</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L173" href="#L173">173</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L174" href="#L174">174</a><span class="code-text"><a-p>### </a-p><a-tt>Implement extension parsing</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L175" href="#L175">175</a><span class="code-text"><a-p>The parse_extension is used to determine which extension the instruction belongs to.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L176" href="#L176">176</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L177" href="#L177">177</a><span class="code-text"><a-p>fn </a-p><a-f>parse_extension</a-f><a-p>(</a-p><a-v>self</a-v><a-p>) -&gt; </a-p><a-t>Result</a-t><a-p>&lt;</a-p><a-t>Extensions</a-t><a-p>, </a-p><a-t>DecodingError</a-t><a-p>&gt; {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L178" href="#L178">178</a><span class="code-text"><a-p>    </a-p><a-c>// ...</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L179" href="#L179">179</a><span class="code-text"><a-p>    </a-p><a-k>let</a-k><a-p> csr: </a-p><a-t>u16</a-t><a-p> = u16::</a-p><a-f>try_from</a-f><a-p>(</a-p><a-v>self</a-v><a-p>.</a-p><a-f>slice</a-f><a-p>(</a-p><a-co>31</a-co><a-p>, </a-p><a-co>20</a-co><a-p>)).</a-p><a-f>unwrap</a-f><a-p>();</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L180" href="#L180">180</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L181" href="#L181">181</a><span class="code-text"><a-p>    </a-p><a-k>match</a-k><a-p> opmap {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L182" href="#L182">182</a><span class="code-text"><a-p>        </a-p><a-c>// ...</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L183" href="#L183">183</a><span class="code-text"><a-p>        </a-p><a-co>0b111_0011</a-co><a-p> =&gt; </a-p><a-k>match</a-k><a-p> funct3 {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L184" href="#L184">184</a><span class="code-text"><a-p>            </a-p><a-co>0b000</a-co><a-p> =&gt; </a-p><a-k>match</a-k><a-p> funct7 {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L185" href="#L185">185</a><span class="code-text"><a-p>                </a-p><a-co>0b000_0000</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>BaseI</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L186" href="#L186">186</a><span class="code-text"><a-p>                _ =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Priv</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L187" href="#L187">187</a><span class="code-text"><a-p>            },</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L188" href="#L188">188</a><span class="code-text"><a-p>            </a-p><a-co>0b010</a-co><a-p> =&gt; </a-p><a-k>match</a-k><a-p> csr {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L189" href="#L189">189</a><span class="code-text"><a-p>                </a-p><a-c>// csrrs rd, (cycle|time|instret), zero</a-c></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L190" href="#L190">190</a><span class="code-text"><a-p>                </a-p><a-co>0xc00</a-co><a-p>..=</a-p><a-co>0xc02</a-co><a-p> | </a-p><a-co>0xc80</a-co><a-p>..=</a-p><a-co>0xc82</a-co><a-p> =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Zicntr</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L191" href="#L191">191</a><span class="code-text"><a-p>                _ =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Zicsr</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L192" href="#L192">192</a><span class="code-text"><a-p>            },</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L193" href="#L193">193</a><span class="code-text"><a-p>            _ =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>Zicsr</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L194" href="#L194">194</a><span class="code-text"><a-p>        },</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L195" href="#L195">195</a><span class="code-text"><a-p>        _ =&gt; </a-p><a-f>Ok</a-f><a-p>(</a-p><a-t>Extensions</a-t><a-p>::</a-p><a-cr>BaseI</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L196" href="#L196">196</a><span class="code-text"><a-p>    }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L197" href="#L197">197</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L198" href="#L198">198</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L199" href="#L199">199</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L200" href="#L200">200</a><span class="code-text"><a-p>### </a-p><a-tt>Re-export</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L201" href="#L201">201</a><span class="code-text"><a-p>Don&#39;t forget to re-export the definition in lib.rs (I forgot to include it to example branch).</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L202" href="#L202">202</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L203" href="#L203">203</a><span class="code-text"><a-p>// re-export definition</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L204" href="#L204">204</a><span class="code-text"><a-p>pub </a-p><a-k>use</a-k><a-p> </a-p><a-k>crate</a-k><a-p>::instruction::{</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L205" href="#L205">205</a><span class="code-text"><a-p>    a_extension::</a-p><a-cr>AOpcode</a-cr><a-p>, base_i::</a-p><a-cr>BaseIOpcode</a-cr><a-p>, c_extension::</a-p><a-cr>COpcode</a-cr><a-p>, m_extension::</a-p><a-cr>MOpcode</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L206" href="#L206">206</a><span class="code-text"><a-p>    priv_extension::</a-p><a-cr>PrivOpcode</a-cr><a-p>, zicsr_extension::</a-p><a-cr>ZicsrOpcode</a-cr><a-p>, zifencei_extension::</a-p><a-cr>ZifenceiOpcode</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L207" href="#L207">207</a><span class="code-text"><a-p>    </a-p><a-cr>InstFormat</a-cr><a-p>, </a-p><a-cr>Instruction</a-cr><a-p>, </a-p><a-cr>OpcodeKind</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L208" href="#L208">208</a><span class="code-text"><a-p>};</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L209" href="#L209">209</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L210" href="#L210">210</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L211" href="#L211">211</a><span class="code-text"><a-p>### </a-p><a-tt>Add unit tests.</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L212" href="#L212">212</a><span class="code-text"><a-p>Add unit tests to decode/inst\_32/xxx_extension.rs.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L213" href="#L213">213</a><span class="code-text"><a-p>```</a-p><a-tl>rust</a-tl></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L214" href="#L214">214</a><span class="code-text"><a-p>#[cfg(test)]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L215" href="#L215">215</a><span class="code-text"><a-p>#[allow(unused_variables)]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L216" href="#L216">216</a><span class="code-text"><a-p>mod test_zicntr {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L217" href="#L217">217</a><span class="code-text"><a-p>    </a-p><a-at>#</a-at><a-p>[</a-p><a-at>test</a-at><a-p>]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L218" href="#L218">218</a><span class="code-text"><a-p>    </a-p><a-at>#</a-at><a-p>[</a-p><a-at>allow</a-at><a-p>(</a-p><a-at>overflowing_literals</a-at><a-p>)]</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L219" href="#L219">219</a><span class="code-text"><a-p>    </a-p><a-k>fn</a-k><a-p> </a-p><a-f>zicntr_decode_test</a-f><a-p>() {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L220" href="#L220">220</a><span class="code-text"><a-p>        </a-p><a-k>use</a-k><a-p> </a-p><a-k>super</a-k><a-p>::</a-p><a-o>*</a-o><a-p>;</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L221" href="#L221">221</a><span class="code-text"><a-p>        </a-p><a-k>use</a-k><a-p> </a-p><a-k>crate</a-k><a-p>::{</a-p><a-cr>Decode</a-cr><a-p>, </a-p><a-cr>Isa</a-cr><a-p>, </a-p><a-cr>OpcodeKind</a-cr><a-p>};</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L222" href="#L222">222</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L223" href="#L223">223</a><span class="code-text"><a-p>        </a-p><a-k>let</a-k><a-p> test_32 = |</a-p><a-v>inst_32</a-v><a-p>: </a-p><a-t>u32</a-t><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L224" href="#L224">224</a><span class="code-text"><a-p>                       </a-p><a-v>op</a-v><a-p>: </a-p><a-t>OpcodeKind</a-t><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L225" href="#L225">225</a><span class="code-text"><a-p>                       </a-p><a-v>rd</a-v><a-p>: </a-p><a-t>Option</a-t><a-p>&lt;</a-p><a-t>usize</a-t><a-p>&gt;,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L226" href="#L226">226</a><span class="code-text"><a-p>                       </a-p><a-v>rs1</a-v><a-p>: </a-p><a-t>Option</a-t><a-p>&lt;</a-p><a-t>usize</a-t><a-p>&gt;,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L227" href="#L227">227</a><span class="code-text"><a-p>                       </a-p><a-v>rs2</a-v><a-p>: </a-p><a-t>Option</a-t><a-p>&lt;</a-p><a-t>usize</a-t><a-p>&gt;,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L228" href="#L228">228</a><span class="code-text"><a-p>                       </a-p><a-v>imm</a-v><a-p>: </a-p><a-t>Option</a-t><a-p>&lt;</a-p><a-t>i32</a-t><a-p>&gt;| {</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L229" href="#L229">229</a><span class="code-text"><a-p>            </a-p><a-k>let</a-k><a-p> op_32 = inst_32.</a-p><a-f>parse_opcode</a-f><a-p>(</a-p><a-t>Isa</a-t><a-p>::</a-p><a-cr>Rv64</a-cr><a-p>).</a-p><a-f>unwrap</a-f><a-p>();</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L230" href="#L230">230</a><span class="code-text"><a-p>            </a-p><a-m>assert!</a-m><a-p>(</a-p><a-m>matches!</a-m><a-p>(</a-p><a-o>&amp;</a-o><a-p>op_32, op));</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L231" href="#L231">231</a><span class="code-text"><a-p>            </a-p><a-m>assert_eq!</a-m><a-p>(inst_32.</a-p><a-f>parse_rd</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-p>op_32).</a-p><a-f>unwrap</a-f><a-p>(), rd);</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L232" href="#L232">232</a><span class="code-text"><a-p>            </a-p><a-m>assert_eq!</a-m><a-p>(inst_32.</a-p><a-f>parse_rs1</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-p>op_32).</a-p><a-f>unwrap</a-f><a-p>(), rs1);</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L233" href="#L233">233</a><span class="code-text"><a-p>            </a-p><a-m>assert_eq!</a-m><a-p>(inst_32.</a-p><a-f>parse_rs2</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-p>op_32).</a-p><a-f>unwrap</a-f><a-p>(), rs2);</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L234" href="#L234">234</a><span class="code-text"><a-p>            </a-p><a-m>assert_eq!</a-m><a-p>(inst_32.</a-p><a-f>parse_imm</a-f><a-p>(</a-p><a-o>&amp;</a-o><a-p>op_32, </a-p><a-t>Isa</a-t><a-p>::</a-p><a-cr>Rv64</a-cr><a-p>).</a-p><a-f>unwrap</a-f><a-p>(), imm);</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L235" href="#L235">235</a><span class="code-text"><a-p>        };</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L236" href="#L236">236</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L237" href="#L237">237</a><span class="code-text"><a-p>        </a-p><a-f>test_32</a-f><a-p>(</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L238" href="#L238">238</a><span class="code-text"><a-p>            </a-p><a-co>0b1100_0000_0001_0000_0010_0111_1111_0011</a-co><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L239" href="#L239">239</a><span class="code-text"><a-p>            </a-p><a-t>OpcodeKind</a-t><a-p>::</a-p><a-f>Zicntr</a-f><a-p>(</a-p><a-t>ZicntrOpcode</a-t><a-p>::</a-p><a-cr>RDTIME</a-cr><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L240" href="#L240">240</a><span class="code-text"><a-p>            </a-p><a-f>Some</a-f><a-p>(</a-p><a-co>15</a-co><a-p>),</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L241" href="#L241">241</a><span class="code-text"><a-p>            </a-p><a-cr>None</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L242" href="#L242">242</a><span class="code-text"><a-p>            </a-p><a-cr>None</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L243" href="#L243">243</a><span class="code-text"><a-p>            </a-p><a-cr>None</a-cr><a-p>,</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L244" href="#L244">244</a><span class="code-text"><a-p>        )</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L245" href="#L245">245</a><span class="code-text"><a-p>    }</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L246" href="#L246">246</a><span class="code-text"><a-p>}</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L247" href="#L247">247</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L248" href="#L248">248</a><span class="code-text"></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L249" href="#L249">249</a><span class="code-text"><a-p>### </a-p><a-tt>Address clippy warnings</a-tt></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L250" href="#L250">250</a><span class="code-text"><a-p>```</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L251" href="#L251">251</a><span class="code-text"><a-p>$ cargo clippy # pedantic is enable by default.</a-p></span><span class="code-break">
</span></span><span class="code-line"><a class="ln" id="L252" href="#L252">252</a><span class="code-text"><a-p>```</a-p></span></span></pre></div></div>
</main>
</body>
</html>
