fork/rules_rust

git clone https://git.julia.blue/fork/rules_rust

Chris FredricksonReplace slashes with underscores in default crate names. (#1336)a066bfed

0.7.0
7.9 KiB269 linesraw
1"""Unit tests for crate names."""
2
3load("@bazel_skylib//lib:unittest.bzl", "analysistest", "asserts")
4load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_shared_library", "rust_static_library", "rust_test")
5load("//test/unit:common.bzl", "assert_argv_contains", "assert_argv_contains_prefix_not")
6
7def _default_crate_name_library_test_impl(ctx):
8    env = analysistest.begin(ctx)
9    tut = analysistest.target_under_test(env)
10
11    # Note: Hyphens in crate name converted to underscores.
12    assert_argv_contains(env, tut.actions[0], "--crate-name=default_crate_name_library")
13    return analysistest.end(env)
14
15def _custom_crate_name_library_test_impl(ctx):
16    env = analysistest.begin(ctx)
17    tut = analysistest.target_under_test(env)
18    assert_argv_contains(env, tut.actions[0], "--crate-name=custom_name")
19    return analysistest.end(env)
20
21def _default_crate_name_binary_test_impl(ctx):
22    env = analysistest.begin(ctx)
23    tut = analysistest.target_under_test(env)
24
25    # Note: Hyphens in crate name converted to underscores.
26    assert_argv_contains(env, tut.actions[0], "--crate-name=default_crate_name_binary")
27    return analysistest.end(env)
28
29def _custom_crate_name_binary_test_impl(ctx):
30    env = analysistest.begin(ctx)
31    tut = analysistest.target_under_test(env)
32    assert_argv_contains(env, tut.actions[0], "--crate-name=custom_name")
33    return analysistest.end(env)
34
35def _default_crate_name_test_test_impl(ctx):
36    env = analysistest.begin(ctx)
37    tut = analysistest.target_under_test(env)
38
39    # Note: Hyphens in crate name converted to underscores.
40    assert_argv_contains(env, tut.actions[0], "--crate-name=default_crate_name_test")
41    return analysistest.end(env)
42
43def _custom_crate_name_test_test_impl(ctx):
44    env = analysistest.begin(ctx)
45    tut = analysistest.target_under_test(env)
46    assert_argv_contains(env, tut.actions[0], "--crate-name=custom_name")
47    return analysistest.end(env)
48
49def _invalid_default_crate_name_test_impl(ctx):
50    env = analysistest.begin(ctx)
51    asserts.expect_failure(env, "contains invalid character(s): @")
52    return analysistest.end(env)
53
54def _invalid_custom_crate_name_test_impl(ctx):
55    env = analysistest.begin(ctx)
56    asserts.expect_failure(env, "contains invalid character(s): -")
57    return analysistest.end(env)
58
59def _slib_library_name_test_impl(ctx):
60    """Regression test for extra-filename.
61
62    Checks that the extra hash value appended to the library filename only
63    contains one dash. Previously, the hash for `slib` was negative,
64    resulting in an extra dash in the filename (--codegen_extra_filename=--NUM).
65
66    Args:
67      ctx: rule context.
68    """
69    env = analysistest.begin(ctx)
70    tut = analysistest.target_under_test(env)
71    assert_argv_contains(env, tut.actions[0], "--codegen=metadata=-2102077805")
72    assert_argv_contains(env, tut.actions[0], "--codegen=extra-filename=-2102077805")
73    return analysistest.end(env)
74
75def _no_extra_filename_test_impl(ctx):
76    """Check that no extra filename is used.
77
78    Args:
79      ctx: rule context.
80    """
81    env = analysistest.begin(ctx)
82    tut = analysistest.target_under_test(env)
83    assert_argv_contains_prefix_not(env, tut.actions[0], "--codegen=metadata=")
84    assert_argv_contains_prefix_not(env, tut.actions[0], "--codegen=extra-filename=")
85    return analysistest.end(env)
86
87default_crate_name_library_test = analysistest.make(
88    _default_crate_name_library_test_impl,
89)
90custom_crate_name_library_test = analysistest.make(
91    _custom_crate_name_library_test_impl,
92)
93default_crate_name_binary_test = analysistest.make(
94    _default_crate_name_binary_test_impl,
95)
96custom_crate_name_binary_test = analysistest.make(
97    _custom_crate_name_binary_test_impl,
98)
99default_crate_name_test_test = analysistest.make(
100    _default_crate_name_test_test_impl,
101)
102custom_crate_name_test_test = analysistest.make(
103    _custom_crate_name_test_test_impl,
104)
105invalid_default_crate_name_test = analysistest.make(
106    _invalid_default_crate_name_test_impl,
107    expect_failure = True,
108)
109invalid_custom_crate_name_test = analysistest.make(
110    _invalid_custom_crate_name_test_impl,
111    expect_failure = True,
112)
113slib_library_name_test = analysistest.make(
114    _slib_library_name_test_impl,
115)
116no_extra_filename_test = analysistest.make(
117    _no_extra_filename_test_impl,
118)
119
120def _crate_name_test():
121    rust_library(
122        name = "default/crate-name-library",
123        srcs = ["lib.rs"],
124        edition = "2018",
125    )
126
127    rust_library(
128        name = "custom-crate-name-library",
129        crate_name = "custom_name",
130        srcs = ["lib.rs"],
131        edition = "2018",
132    )
133
134    rust_binary(
135        name = "default/crate-name-binary",
136        srcs = ["main.rs"],
137        edition = "2018",
138    )
139
140    rust_binary(
141        name = "custom-crate-name-binary",
142        crate_name = "custom_name",
143        srcs = ["main.rs"],
144        edition = "2018",
145    )
146
147    rust_test(
148        name = "default/crate-name-test",
149        srcs = ["main.rs"],
150        edition = "2018",
151    )
152
153    rust_test(
154        name = "custom-crate-name-test",
155        crate_name = "custom_name",
156        srcs = ["main.rs"],
157        edition = "2018",
158    )
159
160    rust_library(
161        name = "invalid@default-crate-name",
162        srcs = ["lib.rs"],
163        edition = "2018",
164        tags = ["manual", "norustfmt"],
165    )
166
167    rust_library(
168        name = "invalid-custom-crate-name",
169        crate_name = "hyphens-not-allowed",
170        srcs = ["lib.rs"],
171        edition = "2018",
172        tags = ["manual", "norustfmt"],
173    )
174
175    rust_library(
176        name = "slib",
177        srcs = ["slib.rs"],
178        edition = "2018",
179    )
180
181    rust_shared_library(
182        name = "shared_lib",
183        srcs = ["lib.rs"],
184        edition = "2018",
185    )
186
187    rust_static_library(
188        name = "static_lib",
189        srcs = ["lib.rs"],
190        edition = "2018",
191    )
192
193    slib_library_name_test(
194        name = "slib_library_name_test",
195        target_under_test = ":slib",
196    )
197
198    default_crate_name_library_test(
199        name = "default_crate_name_library_test",
200        target_under_test = ":default/crate-name-library",
201    )
202
203    custom_crate_name_library_test(
204        name = "custom_crate_name_library_test",
205        target_under_test = ":custom-crate-name-library",
206    )
207
208    default_crate_name_binary_test(
209        name = "default_crate_name_binary_test",
210        target_under_test = ":default/crate-name-binary",
211    )
212
213    custom_crate_name_binary_test(
214        name = "custom_crate_name_binary_test",
215        target_under_test = ":custom-crate-name-binary",
216    )
217
218    default_crate_name_test_test(
219        name = "default_crate_name_test_test",
220        target_under_test = ":default/crate-name-test",
221    )
222
223    custom_crate_name_test_test(
224        name = "custom_crate_name_test_test",
225        target_under_test = ":custom-crate-name-test",
226    )
227
228    invalid_default_crate_name_test(
229        name = "invalid_default_crate_name_test",
230        target_under_test = ":invalid@default-crate-name",
231    )
232
233    invalid_custom_crate_name_test(
234        name = "invalid_custom_crate_name_test",
235        target_under_test = ":invalid-custom-crate-name",
236    )
237
238    no_extra_filename_test(
239        name = "no_extra_filename_for_shared_library_test",
240        target_under_test = ":shared_lib",
241    )
242
243    no_extra_filename_test(
244        name = "no_extra_filename_for_static_library_test",
245        target_under_test = ":static_lib",
246    )
247
248def crate_name_test_suite(name):
249    """Entry-point macro called from the BUILD file.
250
251    Args:
252        name: Name of the macro.
253    """
254
255    _crate_name_test()
256
257    native.test_suite(
258        name = name,
259        tests = [
260            ":default_crate_name_library_test",
261            ":custom_crate_name_library_test",
262            ":default_crate_name_binary_test",
263            ":custom_crate_name_binary_test",
264            ":default_crate_name_test_test",
265            ":custom_crate_name_test_test",
266            ":invalid_default_crate_name_test",
267            ":invalid_custom_crate_name_test",
268        ],
269    )