fork/rust
git clone https://git.julia.blue/fork/rust
3bcad65fbf6
master
1error: usage of `contains_key` followed by `insert` on a `HashMap` 2 --> $DIR/entry.rs:24:5 3 | 4LL | / if !m.contains_key(&k) { 5LL | | m.insert(k, v); 6LL | | } 7 | |_____^ help: try: `m.entry(k).or_insert(v);` 8 | 9 = note: `-D clippy::map-entry` implied by `-D warnings` 10 = help: to override `-D warnings` add `#[allow(clippy::map_entry)]` 11 12error: usage of `contains_key` followed by `insert` on a `HashMap` 13 --> $DIR/entry.rs:29:5 14 | 15LL | / if !m.contains_key(&k) { 16LL | | if true { 17LL | | m.insert(k, v); 18LL | | } else { 19LL | | m.insert(k, v2); 20LL | | } 21LL | | } 22 | |_____^ 23 | 24help: try 25 | 26LL ~ m.entry(k).or_insert_with(|| { 27LL + if true { 28LL + v 29LL + } else { 30LL + v2 31LL + } 32LL + }); 33 | 34 35error: usage of `contains_key` followed by `insert` on a `HashMap` 36 --> $DIR/entry.rs:38:5 37 | 38LL | / if !m.contains_key(&k) { 39LL | | if true { 40LL | | m.insert(k, v) 41LL | | } else { 42LL | | m.insert(k, v2) 43LL | | }; 44LL | | } 45 | |_____^ 46 | 47help: try 48 | 49LL ~ m.entry(k).or_insert_with(|| { 50LL + if true { 51LL + v 52LL + } else { 53LL + v2 54LL + } 55LL + }); 56 | 57 58error: usage of `contains_key` followed by `insert` on a `HashMap` 59 --> $DIR/entry.rs:47:5 60 | 61LL | / if !m.contains_key(&k) { 62LL | | if true { 63LL | | m.insert(k, v); 64LL | | } else { 65... | 66LL | | } 67LL | | } 68 | |_____^ 69 | 70help: try 71 | 72LL ~ if let std::collections::hash_map::Entry::Vacant(e) = m.entry(k) { 73LL + if true { 74LL + e.insert(v); 75LL + } else { 76LL + e.insert(v2); 77LL + return; 78LL + } 79LL + } 80 | 81 82error: usage of `contains_key` followed by `insert` on a `HashMap` 83 --> $DIR/entry.rs:57:5 84 | 85LL | / if !m.contains_key(&k) { 86LL | | foo(); 87LL | | m.insert(k, v); 88LL | | } 89 | |_____^ 90 | 91help: try 92 | 93LL ~ m.entry(k).or_insert_with(|| { 94LL + foo(); 95LL + v 96LL + }); 97 | 98 99error: usage of `contains_key` followed by `insert` on a `HashMap` 100 --> $DIR/entry.rs:63:5 101 | 102LL | / if !m.contains_key(&k) { 103LL | | match 0 { 104LL | | 1 if true => { 105LL | | m.insert(k, v); 106... | 107LL | | }; 108LL | | } 109 | |_____^ 110 | 111help: try 112 | 113LL ~ m.entry(k).or_insert_with(|| { 114LL + match 0 { 115LL + 1 if true => { 116LL + v 117LL + }, 118LL + _ => { 119LL + v2 120LL + }, 121LL + } 122LL + }); 123 | 124 125error: usage of `contains_key` followed by `insert` on a `HashMap` 126 --> $DIR/entry.rs:75:5 127 | 128LL | / if !m.contains_key(&k) { 129LL | | match 0 { 130LL | | 0 => foo(), 131LL | | _ => { 132... | 133LL | | }; 134LL | | } 135 | |_____^ 136 | 137help: try 138 | 139LL ~ if let std::collections::hash_map::Entry::Vacant(e) = m.entry(k) { 140LL + match 0 { 141LL + 0 => foo(), 142LL + _ => { 143LL + e.insert(v2); 144LL + }, 145LL + }; 146LL + } 147 | 148 149error: usage of `contains_key` followed by `insert` on a `HashMap` 150 --> $DIR/entry.rs:85:5 151 | 152LL | / if !m.contains_key(&k) { 153LL | | foo(); 154LL | | match 0 { 155LL | | 0 if false => { 156... | 157LL | | } 158LL | | } 159 | |_____^ 160 | 161help: try 162 | 163LL ~ m.entry(k).or_insert_with(|| { 164LL + foo(); 165LL + match 0 { 166LL + 0 if false => { 167LL + v 168LL + }, 169LL + 1 => { 170LL + foo(); 171LL + v 172LL + }, 173LL + 2 | 3 => { 174LL + for _ in 0..2 { 175LL + foo(); 176LL + } 177LL + if true { 178LL + v 179LL + } else { 180LL + v2 181LL + } 182LL + }, 183LL + _ => { 184LL + v2 185LL + }, 186LL + } 187LL + }); 188 | 189 190error: usage of `contains_key` followed by `insert` on a `HashMap` 191 --> $DIR/entry.rs:119:5 192 | 193LL | / if !m.contains_key(&m!(k)) { 194LL | | m.insert(m!(k), m!(v)); 195LL | | } 196 | |_____^ help: try: `m.entry(m!(k)).or_insert_with(|| m!(v));` 197 198error: usage of `contains_key` followed by `insert` on a `HashMap` 199 --> $DIR/entry.rs:151:5 200 | 201LL | / if !m.contains_key(&k) { 202LL | | let x = (String::new(), String::new()); 203LL | | let _ = x.0; 204LL | | m.insert(k, v); 205LL | | } 206 | |_____^ 207 | 208help: try 209 | 210LL ~ m.entry(k).or_insert_with(|| { 211LL + let x = (String::new(), String::new()); 212LL + let _ = x.0; 213LL + v 214LL + }); 215 | 216 217error: aborting due to 10 previous errors 218