fork/rust

git clone https://git.julia.blue/fork/rust

borsAuto merge of #103046 - JanBeh:PR_clarify_cmp_terminology, r=workingjubilee3bcad65fbf6

master
3.0 KiB91 linesraw
1#![warn(clippy::iter_kv_map)]
2#![allow(unused_mut, clippy::redundant_clone, clippy::suspicious_map, clippy::map_identity)]
3
4use std::collections::{BTreeMap, HashMap};
5
6fn main() {
7    let get_key = |(key, _val)| key;
8    fn ref_acceptor(v: &u32) -> u32 {
9        *v
10    }
11
12    let map: HashMap<u32, u32> = HashMap::new();
13
14    let _ = map.keys().collect::<Vec<_>>();
15    let _ = map.values().collect::<Vec<_>>();
16    let _ = map.values().map(|v| v + 2).collect::<Vec<_>>();
17
18    let _ = map.clone().into_keys().collect::<Vec<_>>();
19    let _ = map.clone().into_keys().map(|key| key + 2).collect::<Vec<_>>();
20
21    let _ = map.clone().into_values().collect::<Vec<_>>();
22    let _ = map.clone().into_values().map(|val| val + 2).collect::<Vec<_>>();
23
24    let _ = map.clone().values().collect::<Vec<_>>();
25    let _ = map.keys().filter(|x| *x % 2 == 0).count();
26
27    // Don't lint
28    let _ = map.iter().filter(|(_, val)| *val % 2 == 0).map(|(key, _)| key).count();
29    let _ = map.iter().map(get_key).collect::<Vec<_>>();
30
31    // Linting the following could be an improvement to the lint
32    // map.iter().filter_map(|(_, val)| (val % 2 == 0).then(val * 17)).count();
33
34    // Lint
35    let _ = map.keys().map(|key| key * 9).count();
36    let _ = map.values().map(|value| value * 17).count();
37
38    // Preserve the ref in the fix.
39    let _ = map.clone().into_values().map(|ref val| ref_acceptor(val)).count();
40
41    // Preserve the mut in the fix.
42    let _ = map
43        .clone().into_values().map(|mut val| {
44            val += 2;
45            val
46        })
47        .count();
48
49    // Don't let a mut interfere.
50    let _ = map.clone().into_values().count();
51
52    let map: BTreeMap<u32, u32> = BTreeMap::new();
53
54    let _ = map.keys().collect::<Vec<_>>();
55    let _ = map.values().collect::<Vec<_>>();
56    let _ = map.values().map(|v| v + 2).collect::<Vec<_>>();
57
58    let _ = map.clone().into_keys().collect::<Vec<_>>();
59    let _ = map.clone().into_keys().map(|key| key + 2).collect::<Vec<_>>();
60
61    let _ = map.clone().into_values().collect::<Vec<_>>();
62    let _ = map.clone().into_values().map(|val| val + 2).collect::<Vec<_>>();
63
64    let _ = map.clone().values().collect::<Vec<_>>();
65    let _ = map.keys().filter(|x| *x % 2 == 0).count();
66
67    // Don't lint
68    let _ = map.iter().filter(|(_, val)| *val % 2 == 0).map(|(key, _)| key).count();
69    let _ = map.iter().map(get_key).collect::<Vec<_>>();
70
71    // Linting the following could be an improvement to the lint
72    // map.iter().filter_map(|(_, val)| (val % 2 == 0).then(val * 17)).count();
73
74    // Lint
75    let _ = map.keys().map(|key| key * 9).count();
76    let _ = map.values().map(|value| value * 17).count();
77
78    // Preserve the ref in the fix.
79    let _ = map.clone().into_values().map(|ref val| ref_acceptor(val)).count();
80
81    // Preserve the mut in the fix.
82    let _ = map
83        .clone().into_values().map(|mut val| {
84            val += 2;
85            val
86        })
87        .count();
88
89    // Don't let a mut interfere.
90    let _ = map.clone().into_values().count();
91}