fork/rust
git clone https://git.julia.blue/fork/rust
3bcad65fbf6
master
1error: unnecessarily eager cloning of iterator items 2 --> $DIR/iter_overeager_cloned.rs:7:29 3 | 4LL | let _: Option<String> = vec.iter().cloned().last(); 5 | ^^^^^^^^^^---------------- 6 | | 7 | help: try: `.last().cloned()` 8 | 9 = note: `-D clippy::iter-overeager-cloned` implied by `-D warnings` 10 = help: to override `-D warnings` add `#[allow(clippy::iter_overeager_cloned)]` 11 12error: unnecessarily eager cloning of iterator items 13 --> $DIR/iter_overeager_cloned.rs:9:29 14 | 15LL | let _: Option<String> = vec.iter().chain(vec.iter()).cloned().next(); 16 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------- 17 | | 18 | help: try: `.next().cloned()` 19 20error: unneeded cloning of iterator items 21 --> $DIR/iter_overeager_cloned.rs:11:20 22 | 23LL | let _: usize = vec.iter().filter(|x| x == &"2").cloned().count(); 24 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- 25 | | 26 | help: try: `.count()` 27 | 28 = note: `-D clippy::redundant-clone` implied by `-D warnings` 29 = help: to override `-D warnings` add `#[allow(clippy::redundant_clone)]` 30 31error: unnecessarily eager cloning of iterator items 32 --> $DIR/iter_overeager_cloned.rs:13:21 33 | 34LL | let _: Vec<_> = vec.iter().cloned().take(2).collect(); 35 | ^^^^^^^^^^----------------- 36 | | 37 | help: try: `.take(2).cloned()` 38 39error: unnecessarily eager cloning of iterator items 40 --> $DIR/iter_overeager_cloned.rs:15:21 41 | 42LL | let _: Vec<_> = vec.iter().cloned().skip(2).collect(); 43 | ^^^^^^^^^^----------------- 44 | | 45 | help: try: `.skip(2).cloned()` 46 47error: unnecessarily eager cloning of iterator items 48 --> $DIR/iter_overeager_cloned.rs:17:13 49 | 50LL | let _ = vec.iter().filter(|x| x == &"2").cloned().nth(2); 51 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------- 52 | | 53 | help: try: `.nth(2).cloned()` 54 55error: unnecessarily eager cloning of iterator items 56 --> $DIR/iter_overeager_cloned.rs:19:13 57 | 58LL | let _ = [Some(Some("str".to_string())), Some(Some("str".to_string()))] 59 | _____________^ 60LL | | .iter() 61LL | | .cloned() 62LL | | .flatten(); 63 | |__________________^ 64 | 65help: try 66 | 67LL ~ .iter() 68LL ~ .flatten().cloned(); 69 | 70 71error: unnecessarily eager cloning of iterator items 72 --> $DIR/iter_overeager_cloned.rs:24:13 73 | 74LL | let _ = vec.iter().cloned().filter(|x| x.starts_with('2')); 75 | ^^^^^^^^^^---------------------------------------- 76 | | 77 | help: try: `.filter(|&x| x.starts_with('2')).cloned()` 78 79error: unnecessarily eager cloning of iterator items 80 --> $DIR/iter_overeager_cloned.rs:26:13 81 | 82LL | let _ = vec.iter().cloned().find(|x| x == "2"); 83 | ^^^^^^^^^^---------------------------- 84 | | 85 | help: try: `.find(|&x| x == "2").cloned()` 86 87error: unnecessarily eager cloning of iterator items 88 --> $DIR/iter_overeager_cloned.rs:30:17 89 | 90LL | let _ = vec.iter().cloned().filter(f); 91 | ^^^^^^^^^^------------------- 92 | | 93 | help: try: `.filter(|&x| f(x)).cloned()` 94 95error: unnecessarily eager cloning of iterator items 96 --> $DIR/iter_overeager_cloned.rs:31:17 97 | 98LL | let _ = vec.iter().cloned().find(f); 99 | ^^^^^^^^^^----------------- 100 | | 101 | help: try: `.find(|&x| f(x)).cloned()` 102 103error: unnecessarily eager cloning of iterator items 104 --> $DIR/iter_overeager_cloned.rs:37:17 105 | 106LL | let _ = vec.iter().cloned().filter(f); 107 | ^^^^^^^^^^------------------- 108 | | 109 | help: try: `.filter(|&x| f(x)).cloned()` 110 111error: unnecessarily eager cloning of iterator items 112 --> $DIR/iter_overeager_cloned.rs:38:17 113 | 114LL | let _ = vec.iter().cloned().find(f); 115 | ^^^^^^^^^^----------------- 116 | | 117 | help: try: `.find(|&x| f(x)).cloned()` 118 119error: unnecessarily eager cloning of iterator items 120 --> $DIR/iter_overeager_cloned.rs:45:9 121 | 122LL | iter.cloned().filter(move |(&a, b)| a == 1 && b == &target) 123 | ^^^^------------------------------------------------------- 124 | | 125 | help: try: `.filter(move |&(&a, b)| a == 1 && b == &target).cloned()` 126 127error: unnecessarily eager cloning of iterator items 128 --> $DIR/iter_overeager_cloned.rs:56:13 129 | 130LL | iter.cloned().filter(move |S { a, b }| **a == 1 && b == &target) 131 | ^^^^------------------------------------------------------------ 132 | | 133 | help: try: `.filter(move |&S { a, b }| **a == 1 && b == &target).cloned()` 134 135error: unneeded cloning of iterator items 136 --> $DIR/iter_overeager_cloned.rs:60:13 137 | 138LL | let _ = vec.iter().cloned().map(|x| x.len()); 139 | ^^^^^^^^^^-------------------------- 140 | | 141 | help: try: `.map(|x| x.len())` 142 143error: unneeded cloning of iterator items 144 --> $DIR/iter_overeager_cloned.rs:65:13 145 | 146LL | let _ = vec.iter().cloned().for_each(|x| assert!(!x.is_empty())); 147 | ^^^^^^^^^^---------------------------------------------- 148 | | 149 | help: try: `.for_each(|x| assert!(!x.is_empty()))` 150 151error: unneeded cloning of iterator items 152 --> $DIR/iter_overeager_cloned.rs:67:13 153 | 154LL | let _ = vec.iter().cloned().all(|x| x.len() == 1); 155 | ^^^^^^^^^^------------------------------- 156 | | 157 | help: try: `.all(|x| x.len() == 1)` 158 159error: unneeded cloning of iterator items 160 --> $DIR/iter_overeager_cloned.rs:69:13 161 | 162LL | let _ = vec.iter().cloned().any(|x| x.len() == 1); 163 | ^^^^^^^^^^------------------------------- 164 | | 165 | help: try: `.any(|x| x.len() == 1)` 166 167error: aborting due to 19 previous errors 168