fork/rust

git clone https://git.julia.blue/fork/rust

borsAuto merge of #103046 - JanBeh:PR_clarify_cmp_terminology, r=workingjubilee3bcad65fbf6

master
3.4 KiB181 linesraw
1#![feature(lint_reasons)]
2#![warn(clippy::let_unit_value)]
3#![allow(unused, clippy::no_effect, clippy::needless_late_init, path_statements)]
4
5macro_rules! let_and_return {
6    ($n:expr) => {{
7        let ret = $n;
8    }};
9}
10
11fn main() {
12    println!("x");
13    let _y = 1; // this is fine
14    let _z = ((), 1); // this as well
15    if true {
16        ();
17    }
18
19    consume_units_with_for_loop(); // should be fine as well
20
21    multiline_sugg();
22
23    let_and_return!(()) // should be fine
24}
25
26// Related to issue #1964
27fn consume_units_with_for_loop() {
28    // `for_let_unit` lint should not be triggered by consuming them using for loop.
29    let v = vec![(), (), ()];
30    let mut count = 0;
31    for _ in v {
32        count += 1;
33    }
34    assert_eq!(count, 3);
35
36    // Same for consuming from some other Iterator<Item = ()>.
37    let (tx, rx) = ::std::sync::mpsc::channel();
38    tx.send(()).unwrap();
39    drop(tx);
40
41    count = 0;
42    for _ in rx.iter() {
43        count += 1;
44    }
45    assert_eq!(count, 1);
46}
47
48fn multiline_sugg() {
49    let v: Vec<u8> = vec![2];
50
51    v
52        .into_iter()
53        .map(|i| i * 2)
54        .filter(|i| i % 2 == 0)
55        .map(|_| ())
56        .next()
57        .unwrap();
58}
59
60#[derive(Copy, Clone)]
61pub struct ContainsUnit(()); // should be fine
62
63fn _returns_generic() {
64    fn f<T>() -> T {
65        unimplemented!()
66    }
67    fn f2<T, U>(_: T) -> U {
68        unimplemented!()
69    }
70    fn f3<T>(x: T) -> T {
71        x
72    }
73    fn f5<T: Default>(x: bool) -> Option<T> {
74        x.then(|| T::default())
75    }
76
77    let _: () = f(); // Ok
78    let _: () = f(); // Lint.
79
80    let _: () = f2(0i32); // Ok
81    let _: () = f2(0i32); // Lint.
82
83    f3(()); // Lint
84    f3(()); // Lint
85
86    // Should lint:
87    // fn f4<T>(mut x: Vec<T>) -> T {
88    //    x.pop().unwrap()
89    // }
90    // let _: () = f4(vec![()]);
91    // let x: () = f4(vec![()]);
92
93    // Ok
94    let _: () = {
95        let x = 5;
96        f2(x)
97    };
98
99    let _: () = if true { f() } else { f2(0) }; // Ok
100    let _: () = if true { f() } else { f2(0) }; // Lint
101
102    // Ok
103    let _: () = match Some(0) {
104        None => f2(1),
105        Some(0) => f(),
106        Some(1) => f2(3),
107        Some(_) => f2('x'),
108    };
109
110    // Lint
111    match Some(0) {
112        None => f2(1),
113        Some(0) => f(),
114        Some(1) => f2(3),
115        Some(_) => (),
116    };
117
118    let _: () = f5(true).unwrap();
119
120    #[allow(clippy::let_unit_value)]
121    {
122        let x = f();
123        let y;
124        let z;
125        match 0 {
126            0 => {
127                y = f();
128                z = f();
129            },
130            1 => {
131                println!("test");
132                y = f();
133                z = f3(());
134            },
135            _ => panic!(),
136        }
137
138        let x1;
139        let x2;
140        if true {
141            x1 = f();
142            x2 = x1;
143        } else {
144            x2 = f();
145            x1 = x2;
146        }
147
148        let opt;
149        match f5(true) {
150            Some(x) => opt = x,
151            None => panic!(),
152        };
153
154        #[warn(clippy::let_unit_value)]
155        {
156            let _: () = x;
157            let _: () = y;
158            z;
159            let _: () = x1;
160            let _: () = x2;
161            let _: () = opt;
162        }
163    }
164
165    let () = f();
166}
167
168fn attributes() {
169    fn f() {}
170
171    #[allow(clippy::let_unit_value)]
172    let _ = f();
173    #[expect(clippy::let_unit_value)]
174    let _ = f();
175}
176
177async fn issue10433() {
178    let _pending: () = std::future::pending().await;
179}
180
181pub async fn issue11502(a: ()) {}