fork/rust

git clone https://git.julia.blue/fork/rust

borsAuto merge of #103046 - JanBeh:PR_clarify_cmp_terminology, r=workingjubilee3bcad65fbf6

master
9.8 KiB376 linesraw
1error: this could be rewritten as `let...else`
2  --> $DIR/manual_let_else.rs:25:5
3   |
4LL |     let v = if let Some(v_some) = g() { v_some } else { return };
5   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Some(v) = g() else { return };`
6   |
7   = note: `-D clippy::manual-let-else` implied by `-D warnings`
8   = help: to override `-D warnings` add `#[allow(clippy::manual_let_else)]`
9
10error: this could be rewritten as `let...else`
11  --> $DIR/manual_let_else.rs:28:5
12   |
13LL | /     let v = if let Some(v_some) = g() {
14LL | |
15LL | |         v_some
16LL | |     } else {
17LL | |         return;
18LL | |     };
19   | |______^
20   |
21help: consider writing
22   |
23LL ~     let Some(v) = g() else {
24LL +         return;
25LL +     };
26   |
27
28error: this could be rewritten as `let...else`
29  --> $DIR/manual_let_else.rs:35:5
30   |
31LL | /     let v = if let Some(v) = g() {
32LL | |
33LL | |         // Blocks around the identity should have no impact
34LL | |         {
35...  |
36LL | |         return;
37LL | |     };
38   | |______^
39   |
40help: consider writing
41   |
42LL ~     let Some(v) = g() else {
43LL +         // Some computation should still make it fire
44LL +         g();
45LL +         return;
46LL +     };
47   |
48
49error: this could be rewritten as `let...else`
50  --> $DIR/manual_let_else.rs:49:9
51   |
52LL |         let v = if let Some(v_some) = g() { v_some } else { continue };
53   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Some(v) = g() else { continue };`
54
55error: this could be rewritten as `let...else`
56  --> $DIR/manual_let_else.rs:51:9
57   |
58LL |         let v = if let Some(v_some) = g() { v_some } else { break };
59   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Some(v) = g() else { break };`
60
61error: this could be rewritten as `let...else`
62  --> $DIR/manual_let_else.rs:56:5
63   |
64LL |     let v = if let Some(v_some) = g() { v_some } else { panic!() };
65   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Some(v) = g() else { panic!() };`
66
67error: this could be rewritten as `let...else`
68  --> $DIR/manual_let_else.rs:60:5
69   |
70LL | /     let v = if let Some(v_some) = g() {
71LL | |
72LL | |         v_some
73LL | |     } else {
74LL | |         std::process::abort()
75LL | |     };
76   | |______^
77   |
78help: consider writing
79   |
80LL ~     let Some(v) = g() else {
81LL +         std::process::abort()
82LL +     };
83   |
84
85error: this could be rewritten as `let...else`
86  --> $DIR/manual_let_else.rs:68:5
87   |
88LL | /     let v = if let Some(v_some) = g() {
89LL | |
90LL | |         v_some
91LL | |     } else {
92LL | |         if true { return } else { panic!() }
93LL | |     };
94   | |______^
95   |
96help: consider writing
97   |
98LL ~     let Some(v) = g() else {
99LL +         if true { return } else { panic!() }
100LL +     };
101   |
102
103error: this could be rewritten as `let...else`
104  --> $DIR/manual_let_else.rs:76:5
105   |
106LL | /     let v = if let Some(v_some) = g() {
107LL | |
108LL | |         v_some
109LL | |     } else {
110LL | |         if true {}
111LL | |         panic!();
112LL | |     };
113   | |______^
114   |
115help: consider writing
116   |
117LL ~     let Some(v) = g() else {
118LL +         if true {}
119LL +         panic!();
120LL +     };
121   |
122
123error: this could be rewritten as `let...else`
124  --> $DIR/manual_let_else.rs:87:5
125   |
126LL | /     let v = if let Some(v_some) = g() {
127LL | |
128LL | |         v_some
129LL | |     } else {
130...  |
131LL | |         }
132LL | |     };
133   | |______^
134   |
135help: consider writing
136   |
137LL ~     let Some(v) = g() else {
138LL +         match () {
139LL +             _ if panic!() => {},
140LL +             _ => panic!(),
141LL +         }
142LL +     };
143   |
144
145error: this could be rewritten as `let...else`
146  --> $DIR/manual_let_else.rs:98:5
147   |
148LL |     let v = if let Some(v_some) = g() { v_some } else { if panic!() {} };
149   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Some(v) = g() else { if panic!() {} };`
150
151error: this could be rewritten as `let...else`
152  --> $DIR/manual_let_else.rs:102:5
153   |
154LL | /     let v = if let Some(v_some) = g() {
155LL | |
156LL | |         v_some
157LL | |     } else {
158...  |
159LL | |         }
160LL | |     };
161   | |______^
162   |
163help: consider writing
164   |
165LL ~     let Some(v) = g() else {
166LL +         match panic!() {
167LL +             _ => {},
168LL +         }
169LL +     };
170   |
171
172error: this could be rewritten as `let...else`
173  --> $DIR/manual_let_else.rs:112:5
174   |
175LL | /     let v = if let Some(v_some) = g() {
176LL | |
177LL | |         v_some
178LL | |     } else if true {
179...  |
180LL | |         panic!("diverge");
181LL | |     };
182   | |______^
183   |
184help: consider writing
185   |
186LL ~     let Some(v) = g() else { if true {
187LL +         return;
188LL +     } else {
189LL +         panic!("diverge");
190LL +     } };
191   |
192
193error: this could be rewritten as `let...else`
194  --> $DIR/manual_let_else.rs:122:5
195   |
196LL | /     let v = if let Some(v_some) = g() {
197LL | |
198LL | |         v_some
199LL | |     } else {
200...  |
201LL | |         }
202LL | |     };
203   | |______^
204   |
205help: consider writing
206   |
207LL ~     let Some(v) = g() else {
208LL +         match (g(), g()) {
209LL +             (Some(_), None) => return,
210LL +             (None, Some(_)) => {
211LL +                 if true {
212LL +                     return;
213LL +                 } else {
214LL +                     panic!();
215LL +                 }
216LL +             },
217LL +             _ => return,
218LL +         }
219LL +     };
220   |
221
222error: this could be rewritten as `let...else`
223  --> $DIR/manual_let_else.rs:140:5
224   |
225LL | /     let (v, w) = if let Some(v_some) = g().map(|v| (v, 42)) {
226LL | |
227LL | |         v_some
228LL | |     } else {
229LL | |         return;
230LL | |     };
231   | |______^
232   |
233help: consider writing
234   |
235LL ~     let Some((v, w)) = g().map(|v| (v, 42)) else {
236LL +         return;
237LL +     };
238   |
239
240error: this could be rewritten as `let...else`
241  --> $DIR/manual_let_else.rs:148:5
242   |
243LL | /     let (w, S { v }) = if let (Some(v_some), w_some) = (g().map(|_| S { v: 0 }), 0) {
244LL | |
245LL | |         (w_some, v_some)
246LL | |     } else {
247LL | |         return;
248LL | |     };
249   | |______^
250   |
251help: consider writing
252   |
253LL ~     let (Some(S { v }), w) = (g().map(|_| S { v: 0 }), 0) else {
254LL +         return;
255LL +     };
256   |
257
258error: this could be rewritten as `let...else`
259  --> $DIR/manual_let_else.rs:158:13
260   |
261LL |             let $n = if let Some(v) = $e { v } else { return };
262   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Some($n) = g() else { return };`
263...
264LL |     create_binding_if_some!(w, g());
265   |     ------------------------------- in this macro invocation
266   |
267   = note: this error originates in the macro `create_binding_if_some` (in Nightly builds, run with -Z macro-backtrace for more info)
268
269error: this could be rewritten as `let...else`
270  --> $DIR/manual_let_else.rs:167:5
271   |
272LL |     let v = if let Variant::A(a, 0) = e() { a } else { return };
273   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Variant::A(v, 0) = e() else { return };`
274
275error: this could be rewritten as `let...else`
276  --> $DIR/manual_let_else.rs:171:5
277   |
278LL |     let mut v = if let Variant::B(b) = e() { b } else { return };
279   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Variant::B(mut v) = e() else { return };`
280
281error: this could be rewritten as `let...else`
282  --> $DIR/manual_let_else.rs:176:5
283   |
284LL | /     let v = if let Ok(Some(Variant::B(b))) | Err(Some(Variant::A(b, _))) = nested {
285LL | |
286LL | |         b
287LL | |     } else {
288LL | |         return;
289LL | |     };
290   | |______^
291   |
292help: consider writing
293   |
294LL ~     let (Ok(Some(Variant::B(v))) | Err(Some(Variant::A(v, _)))) = nested else {
295LL +         return;
296LL +     };
297   |
298
299error: this could be rewritten as `let...else`
300  --> $DIR/manual_let_else.rs:183:5
301   |
302LL |     let v = if let Variant::A(.., a) = e() { a } else { return };
303   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let Variant::A(.., v) = e() else { return };`
304
305error: this could be rewritten as `let...else`
306  --> $DIR/manual_let_else.rs:187:5
307   |
308LL |     let w = if let (Some(v), ()) = (g(), ()) { v } else { return };
309   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `let (Some(w), ()) = (g(), ()) else { return };`
310
311error: this could be rewritten as `let...else`
312  --> $DIR/manual_let_else.rs:191:5
313   |
314LL | /     let w = if let Some(S { v: x }) = Some(S { v: 0 }) {
315LL | |
316LL | |         x
317LL | |     } else {
318LL | |         return;
319LL | |     };
320   | |______^
321   |
322help: consider writing
323   |
324LL ~     let Some(S { v: w }) = Some(S { v: 0 }) else {
325LL +         return;
326LL +     };
327   |
328
329error: this could be rewritten as `let...else`
330  --> $DIR/manual_let_else.rs:199:5
331   |
332LL | /     let v = if let Some(S { v: x }) = Some(S { v: 0 }) {
333LL | |
334LL | |         x
335LL | |     } else {
336LL | |         return;
337LL | |     };
338   | |______^
339   |
340help: consider writing
341   |
342LL ~     let Some(S { v }) = Some(S { v: 0 }) else {
343LL +         return;
344LL +     };
345   |
346
347error: this could be rewritten as `let...else`
348  --> $DIR/manual_let_else.rs:207:5
349   |
350LL | /     let (x, S { v }, w) = if let Some(U { v, w, x }) = None::<U<S<()>>> {
351LL | |
352LL | |         (x, v, w)
353LL | |     } else {
354LL | |         return;
355LL | |     };
356   | |______^
357   |
358help: consider writing
359   |
360LL ~     let Some(U { v: S { v }, w, x }) = None::<U<S<()>>> else {
361LL +         return;
362LL +     };
363   |
364
365error: this could be rewritten as `let...else`
366  --> $DIR/manual_let_else.rs:324:5
367   |
368LL | /     let _ = match ff {
369LL | |
370LL | |         Some(value) => value,
371LL | |         _ => macro_call!(),
372LL | |     };
373   | |______^ help: consider writing: `let Some(_) = ff else { macro_call!() };`
374
375error: aborting due to 26 previous errors
376