fork/rust

git clone https://git.julia.blue/fork/rust

borsAuto merge of #103046 - JanBeh:PR_clarify_cmp_terminology, r=workingjubilee3bcad65fbf6

master
9.4 KiB230 linesraw
1error: useless conversion to the same type: `T`
2  --> $DIR/useless_conversion.rs:5:13
3   |
4LL |     let _ = T::from(val);
5   |             ^^^^^^^^^^^^ help: consider removing `T::from()`: `val`
6   |
7note: the lint level is defined here
8  --> $DIR/useless_conversion.rs:1:9
9   |
10LL | #![deny(clippy::useless_conversion)]
11   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
12
13error: useless conversion to the same type: `T`
14  --> $DIR/useless_conversion.rs:6:5
15   |
16LL |     val.into()
17   |     ^^^^^^^^^^ help: consider removing `.into()`: `val`
18
19error: useless conversion to the same type: `i32`
20  --> $DIR/useless_conversion.rs:18:22
21   |
22LL |         let _: i32 = 0i32.into();
23   |                      ^^^^^^^^^^^ help: consider removing `.into()`: `0i32`
24
25error: useless conversion to the same type: `std::str::Lines<'_>`
26  --> $DIR/useless_conversion.rs:48:22
27   |
28LL |     if Some("ok") == lines.into_iter().next() {}
29   |                      ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `lines`
30
31error: useless conversion to the same type: `std::str::Lines<'_>`
32  --> $DIR/useless_conversion.rs:53:21
33   |
34LL |     let mut lines = text.lines().into_iter();
35   |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `text.lines()`
36
37error: useless conversion to the same type: `std::str::Lines<'_>`
38  --> $DIR/useless_conversion.rs:59:22
39   |
40LL |     if Some("ok") == text.lines().into_iter().next() {}
41   |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `text.lines()`
42
43error: useless conversion to the same type: `std::ops::Range<i32>`
44  --> $DIR/useless_conversion.rs:65:13
45   |
46LL |     let _ = NUMBERS.into_iter().next();
47   |             ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `NUMBERS`
48
49error: useless conversion to the same type: `std::ops::Range<i32>`
50  --> $DIR/useless_conversion.rs:70:17
51   |
52LL |     let mut n = NUMBERS.into_iter();
53   |                 ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `NUMBERS`
54
55error: useless conversion to the same type: `std::string::String`
56  --> $DIR/useless_conversion.rs:132:21
57   |
58LL |     let _: String = "foo".to_string().into();
59   |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"foo".to_string()`
60
61error: useless conversion to the same type: `std::string::String`
62  --> $DIR/useless_conversion.rs:133:21
63   |
64LL |     let _: String = From::from("foo".to_string());
65   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `"foo".to_string()`
66
67error: useless conversion to the same type: `std::string::String`
68  --> $DIR/useless_conversion.rs:134:13
69   |
70LL |     let _ = String::from("foo".to_string());
71   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `"foo".to_string()`
72
73error: useless conversion to the same type: `std::string::String`
74  --> $DIR/useless_conversion.rs:135:13
75   |
76LL |     let _ = String::from(format!("A: {:04}", 123));
77   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("A: {:04}", 123)`
78
79error: useless conversion to the same type: `std::str::Lines<'_>`
80  --> $DIR/useless_conversion.rs:136:13
81   |
82LL |     let _ = "".lines().into_iter();
83   |             ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `"".lines()`
84
85error: useless conversion to the same type: `std::vec::IntoIter<i32>`
86  --> $DIR/useless_conversion.rs:137:13
87   |
88LL |     let _ = vec![1, 2, 3].into_iter().into_iter();
89   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `vec![1, 2, 3].into_iter()`
90
91error: useless conversion to the same type: `std::string::String`
92  --> $DIR/useless_conversion.rs:138:21
93   |
94LL |     let _: String = format!("Hello {}", "world").into();
95   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Hello {}", "world")`
96
97error: useless conversion to the same type: `i32`
98  --> $DIR/useless_conversion.rs:143:13
99   |
100LL |     let _ = i32::from(a + b) * 3;
101   |             ^^^^^^^^^^^^^^^^ help: consider removing `i32::from()`: `(a + b)`
102
103error: useless conversion to the same type: `Foo<'a'>`
104  --> $DIR/useless_conversion.rs:149:23
105   |
106LL |     let _: Foo<'a'> = s2.into();
107   |                       ^^^^^^^^^ help: consider removing `.into()`: `s2`
108
109error: useless conversion to the same type: `Foo<'a'>`
110  --> $DIR/useless_conversion.rs:151:13
111   |
112LL |     let _ = Foo::<'a'>::from(s3);
113   |             ^^^^^^^^^^^^^^^^^^^^ help: consider removing `Foo::<'a'>::from()`: `s3`
114
115error: useless conversion to the same type: `std::vec::IntoIter<Foo<'a'>>`
116  --> $DIR/useless_conversion.rs:153:13
117   |
118LL |     let _ = vec![s4, s4, s4].into_iter().into_iter();
119   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `vec![s4, s4, s4].into_iter()`
120
121error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
122  --> $DIR/useless_conversion.rs:185:7
123   |
124LL |     b(vec![1, 2].into_iter());
125   |       ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `vec![1, 2]`
126   |
127note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
128  --> $DIR/useless_conversion.rs:175:13
129   |
130LL |     fn b<T: IntoIterator<Item = i32>>(_: T) {}
131   |             ^^^^^^^^^^^^^^^^^^^^^^^^
132
133error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
134  --> $DIR/useless_conversion.rs:186:7
135   |
136LL |     c(vec![1, 2].into_iter());
137   |       ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `vec![1, 2]`
138   |
139note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
140  --> $DIR/useless_conversion.rs:176:18
141   |
142LL |     fn c(_: impl IntoIterator<Item = i32>) {}
143   |                  ^^^^^^^^^^^^^^^^^^^^^^^^
144
145error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
146  --> $DIR/useless_conversion.rs:187:7
147   |
148LL |     d(vec![1, 2].into_iter());
149   |       ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `vec![1, 2]`
150   |
151note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
152  --> $DIR/useless_conversion.rs:179:12
153   |
154LL |         T: IntoIterator<Item = i32>,
155   |            ^^^^^^^^^^^^^^^^^^^^^^^^
156
157error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
158  --> $DIR/useless_conversion.rs:190:7
159   |
160LL |     b(vec![1, 2].into_iter().into_iter());
161   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`s: `vec![1, 2]`
162   |
163note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
164  --> $DIR/useless_conversion.rs:175:13
165   |
166LL |     fn b<T: IntoIterator<Item = i32>>(_: T) {}
167   |             ^^^^^^^^^^^^^^^^^^^^^^^^
168
169error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
170  --> $DIR/useless_conversion.rs:191:7
171   |
172LL |     b(vec![1, 2].into_iter().into_iter().into_iter());
173   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`s: `vec![1, 2]`
174   |
175note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
176  --> $DIR/useless_conversion.rs:175:13
177   |
178LL |     fn b<T: IntoIterator<Item = i32>>(_: T) {}
179   |             ^^^^^^^^^^^^^^^^^^^^^^^^
180
181error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
182  --> $DIR/useless_conversion.rs:237:24
183   |
184LL |         foo2::<i32, _>([1, 2, 3].into_iter());
185   |                        ^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[1, 2, 3]`
186   |
187note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
188  --> $DIR/useless_conversion.rs:216:12
189   |
190LL |         I: IntoIterator<Item = i32> + Helper<X>,
191   |            ^^^^^^^^^^^^^^^^^^^^^^^^
192
193error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
194  --> $DIR/useless_conversion.rs:245:14
195   |
196LL |         foo3([1, 2, 3].into_iter());
197   |              ^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[1, 2, 3]`
198   |
199note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
200  --> $DIR/useless_conversion.rs:225:12
201   |
202LL |         I: IntoIterator<Item = i32>,
203   |            ^^^^^^^^^^^^^^^^^^^^^^^^
204
205error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
206  --> $DIR/useless_conversion.rs:254:16
207   |
208LL |         S1.foo([1, 2].into_iter());
209   |                ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[1, 2]`
210   |
211note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
212  --> $DIR/useless_conversion.rs:251:27
213   |
214LL |             pub fn foo<I: IntoIterator>(&self, _: I) {}
215   |                           ^^^^^^^^^^^^
216
217error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
218  --> $DIR/useless_conversion.rs:273:44
219   |
220LL |         v0.into_iter().interleave_shortest(v1.into_iter());
221   |                                            ^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `v1`
222   |
223note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
224  --> $DIR/useless_conversion.rs:260:20
225   |
226LL |                 J: IntoIterator,
227   |                    ^^^^^^^^^^^^
228
229error: aborting due to 28 previous errors
230